From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/6] asus-wmi: Document previously added attributes
Date: Mon, 8 Aug 2022 18:11:32 +0200 [thread overview]
Message-ID: <CAHp75VdJyukGnJkhjPiB7wMxS5aQkVfMwVVhqAxA6DppyH3HLQ@mail.gmail.com> (raw)
In-Reply-To: <20220808030420.8633-5-luke@ljones.dev>
On Mon, Aug 8, 2022 at 5:09 AM Luke D. Jones <luke@ljones.dev> wrote:
>
> Documents some previously added attributes:
> - dgpu_disable
> - egpu_enable
> - panel_od
> - keyboard_rgb_mode
> - keyboard_rgb_state
...
> +What: /sys/devices/platform/<platform>/dgpu_disable
> +Date: Aug 2022
> +KernelVersion: 5.17
> +Contact: "Luke Jones" <luke@ljones.dev>
> +Description:
> + Disable discrete GPU:
> + * 0 - Enable dGPU,
> + * 1 - Disable dGPU,
> +
> +What: /sys/devices/platform/<platform>/egpu_enable
> +Date: Aug 2022
> +KernelVersion: 5.17
> +Contact: "Luke Jones" <luke@ljones.dev>
> +Description:
> + Enable the external GPU paired with ROG X-Flow laptops.
> + Toggling this setting will also trigger ACPI to disable the dGPU:
> + * 0 - Disable,
> + * 1 - Enable,
> +
> +What: /sys/devices/platform/<platform>/panel_od
> +Date: Aug 2022
> +KernelVersion: 5.17
> +Contact: "Luke Jones" <luke@ljones.dev>
> +Description:
> + Enable an LCD response-time boost to reduce or remove ghosting:
> + * 0 - Disable,
> + * 1 - Enable,
These should be in separate patch(es) with the corresponding Fixes
tags. (The latter may not be so important, though. I leave it to Hans
to decide)
...
> +What: /sys/devices/platform/<platform>/keyboard_rgb_mode
> +Date: Aug 2022
> +KernelVersion: 6.0
These should go separately. Dunno if it should be a separate
documentation change for the both, or should it be split and
reattached to the respective patches from the series. Up to Hans.
> +Contact: "Luke Jones" <luke@ljones.dev>
> +Description:
> + Set some RGB keyboard modes and features (write-only).
> +
> + The accepted input is "save mode speed", where "n n n" options
> + are:
> + * save - 0 or 1, if 0 then settings are not retained on boot
> + * mode - 0 to 12, each is an RGB such as static, rainbow, pulse.
> + Not all keyboards accept every mode.
> + * speed - 0, 1, 2, equal to low, medium, high.
> + Only applies to certain modes.
> +
> +What: /sys/devices/platform/<platform>/keyboard_rgb_state
> +Date: Aug 2022
> +KernelVersion: 6.0
> +Contact: "Luke Jones" <luke@ljones.dev>
> +Description:
> + Set some RGB keyboard power states (write-only).
> +
> + The accepted input is "boot awake sleep keyboard", where "n n n n n"
> + options are:
> + * save - 0 or 1, if 0 then settings are not retained on boot
> + * boot - 0 or 1, controls if a boot animation is shown
> + * awake - 0 or 1, controls if the keyboard LED are on during awake
> + * sleep - 0 or 1, controls if a suspended animation is shown.
> + This is only active if the AC is connected.
> + * keyboard - 0 or 1, unknown what effect this really has
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-08 16:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 3:04 [PATCH v2 0/6] asus-wmi: Add support for RGB keyboards Luke D. Jones
2022-08-08 3:04 ` [PATCH v2 1/6] asus-wmi: Implement TUF laptop keyboard RGB control Luke D. Jones
2022-08-08 3:04 ` [PATCH v2 2/6] asus-wmi: Implement TUF laptop keyboard LED modes Luke D. Jones
2022-08-08 16:01 ` Andy Shevchenko
2022-08-08 21:43 ` Luke Jones
2022-08-09 7:20 ` Andy Shevchenko
2022-08-08 3:04 ` [PATCH v2 3/6] asus-wmi: Implement TUF laptop keyboard power states Luke D. Jones
2022-08-08 16:08 ` Andy Shevchenko
2022-08-08 23:27 ` Luke Jones
2022-08-09 8:29 ` Andy Shevchenko
2022-08-09 22:25 ` Luke Jones
2022-08-08 3:04 ` [PATCH v2 4/6] asus-wmi: Document previously added attributes Luke D. Jones
2022-08-08 16:11 ` Andy Shevchenko [this message]
2022-08-08 3:04 ` [PATCH v2 5/6] asus-wmi: Convert all attr-show to use sysfs_emit Luke D. Jones
2022-08-08 16:13 ` Andy Shevchenko
2022-08-08 3:04 ` [PATCH v2 6/6] asus-wmi: Add support for dGPU-only mode Luke D. Jones
2022-08-08 8:38 ` Luke Jones
2022-08-08 15:44 ` Andy Shevchenko
2022-08-08 3:26 ` [PATCH v2 0/6] asus-wmi: Add support for RGB keyboards Luke Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdJyukGnJkhjPiB7wMxS5aQkVfMwVVhqAxA6DppyH3HLQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).