From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chris Blake <chrisrblake93@gmail.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Christian Lamparter <chunkeey@gmail.com>
Subject: Re: [PATCH v2] platform/x86: add meraki-mx100 platform driver
Date: Fri, 6 Aug 2021 16:58:51 +0300 [thread overview]
Message-ID: <CAHp75VeUcrHuBOW9LJ=sPR0atxoEEe19mpD32UfjY1NncD5dLA@mail.gmail.com> (raw)
In-Reply-To: <b5430038-c18c-6037-44d1-a3c0089645a1@redhat.com>
On Fri, Aug 6, 2021 at 4:55 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 8/6/21 9:52 AM, Andy Shevchenko wrote:
> > On Fri, Aug 6, 2021 at 5:47 AM Chris Blake <chrisrblake93@gmail.com> wrote:
...
> >> +#include <linux/gpio/machine.h>
> >
> > Does this provide a GPIO controller driver? I don't think so.
>
> Actually GPIO controller drivers use <linux/gpio/driver.h>
> <linux/gpio/machine.h> for board files / glue code which
> e.g. needs to add lookup-tables, which this code does,
> so including this header is correct.
Ah, indeed. I stand corrected.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-06 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 0:57 [PATCH v2] platform/x86: add meraki-mx100 platform driver Chris Blake
2021-08-06 7:52 ` Andy Shevchenko
2021-08-06 13:55 ` Hans de Goede
2021-08-06 13:58 ` Andy Shevchenko [this message]
2021-08-06 15:37 ` Chris
2021-08-06 15:44 ` Andy Shevchenko
2021-08-09 9:05 ` Lee Jones
2021-08-06 13:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeUcrHuBOW9LJ=sPR0atxoEEe19mpD32UfjY1NncD5dLA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=chrisrblake93@gmail.com \
--cc=chunkeey@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-gpio@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).