platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikita Kravets <teackot@gmail.com>
To: "Barnabás Pőcze" <pobrn@protonmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	Jose Angel Pastrana <japp0005@red.ujaen.es>,
	Aakash Singh <mail@singhaakash.dev>
Subject: Re: [PATCH v2] platform/x86: Add new msi-ec driver
Date: Sat, 11 Mar 2023 23:35:16 +0300	[thread overview]
Message-ID: <CAPXvF05AurS89f6bNg_5-VCS=vX=qMXbKgSdv5-wwBb8J3Xdcw@mail.gmail.com> (raw)
In-Reply-To: <iPt1Reo37oGFvlRdQOY-3kZypWeV0pRah5oZ17K4xUOkeMqE7E43XQVyUX0A4a6oeEc1hPPzbjKcU3NznXUA3fnmp-foM3vuFSnA4YcFTDQ=@protonmail.com>

Hi,

> The above two functions are inconsistent with the rest of the file because
> they have the return type in a separate line.

I believe it was originally made to not exceed the limit of 80 columns

> It's a small thing, but usually /* ... */ comments are preferred.
> Hans will tell you if you need to change it.

Okay

> Previously you said `match_string()` works here. Has something changed?

No, I implemented it in the main repo but forgot to do it in the kernel patch..
I'll do it in the v3 after we're finished reviewing v2

> Why not simply
>
>   conf = *CONFIGURATIONS[i];

Noted

Regards,
Nikita

  reply	other threads:[~2023-03-11 20:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 14:40 [PATCH v2] platform/x86: Add new msi-ec driver Nikita Kravets
2023-03-11 19:25 ` Barnabás Pőcze
2023-03-11 20:35   ` Nikita Kravets [this message]
2023-03-15 11:38     ` Hans de Goede
2023-03-15 14:29       ` Nikita Kravets
2023-03-16 12:01         ` Hans de Goede
2023-03-20 21:26           ` Nikita Kravets
2023-03-20 21:28             ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPXvF05AurS89f6bNg_5-VCS=vX=qMXbKgSdv5-wwBb8J3Xdcw@mail.gmail.com' \
    --to=teackot@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=japp0005@red.ujaen.es \
    --cc=mail@singhaakash.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pobrn@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).