From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 835DDC00140 for ; Tue, 2 Aug 2022 05:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbiHBFoD (ORCPT ); Tue, 2 Aug 2022 01:44:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231804AbiHBFoC (ORCPT ); Tue, 2 Aug 2022 01:44:02 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C0A7422D5; Mon, 1 Aug 2022 22:44:01 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9EB345C0181; Tue, 2 Aug 2022 01:44:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 02 Aug 2022 01:44:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1659419040; x=1659505440; bh=lXKuC3UWWj 6/PrNDZDTucFx+D2EZFW1sZqICFiETZp4=; b=LMKRfUrPfYEIm9UbFjLqBRFuMW SBtw6hZfqwi9yu/1JkOF77+aCeLSnLczSuI6WxpvYWbQ+q1mN8YCJQMeBxshBIPv H7vIlZ2Siu1duN9huKPAE0+RrqvkK5JWW2J7SN+5LkdqDdA5wzWK5cvUpuHpGZIy r5SGV9d/0m7nzWZr5V9je8LlYUZTIShRVy5e8KopHQBlQldlCUV/TLuGo7tWwjpd f89bLUNVUQ3vdkOTigitp9DOeb+cuAQUosAW8KCT9/kLySGqPJ5ZI2WZjCaGp9ii P7q/ByvWWv9kOnseTNbivc4ph5gIOvOv9rmzcX0fxwuWlhr9sIcICo8S38IA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1659419040; x=1659505440; bh=lXKuC3UWWj6/PrNDZDTucFx+D2EZ FW1sZqICFiETZp4=; b=lG9K0y880gFiGur3J7ynA/+/fdSyRCoNojT3Iew0lefr vTRZVVrRm4cSoQQMbsf7Ca5iVDeGhgaDZV+fGu62/zkx5XywB9Q4HVSkDRGXjNhR to0bx0euxk8V8ZilUtrDRrdPIkQOPGjKbWCoCaNYYzpUWdofz/kbB7RlE7ia/rnS yfs7gyaMjcRKecBhX7xt7Lwott+1Rwzsaz+ZqS0yFlAJXstmcKz3B381tPXi4QNq OHlwLbCH7QP9Z0gu5wCvcaXVl8WCiGaNTpYcRp7w4uRcp2aBTuHUj5FwoBsJMqXH fY/HnaL5IxKOyFiyHQ+0NTkb7tmycXAyIoDOOMAHqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvgedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffuvfevkfgjfhfogggtsehttd ertdertddvnecuhfhrohhmpefnuhhkvgculfhonhgvshcuoehluhhkvgeslhhjohhnvghs rdguvghvqeenucggtffrrghtthgvrhhnpedvvdegledtheefieejgfevgeefiefhtdevte efteduhfevtdefleethfetgeeludenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehluhhkvgeslhhjohhnvghsrdguvghv X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Aug 2022 01:43:55 -0400 (EDT) Date: Tue, 02 Aug 2022 17:43:42 +1200 From: Luke Jones Subject: Re: [PATCH] asus-wmi: Add support for TUF laptop keyboard RGB To: hdegoede@redhat.com Cc: corentin.chary@gmail.com, markgross@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Message-Id: In-Reply-To: <20220802045942.1565559-1-luke@ljones.dev> References: <20220802045942.1565559-1-luke@ljones.dev> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org My apologies, I didn't mean to send two emails, I thought the first send was cancelled. This submission is the canonical one. Regards, Luke. On Tue, Aug 2 2022 at 16:59:42 +1200, Luke D. Jones wrote: > Adds support for TUF laptop RGB control. This creates two sysfs > paths to add control of basic keyboard LEDs, and power states. > > /sys/devices/platform/asus-nb-wmi/tuf_krgb_mode has the following > as input options via U8 "n n n n n n": > - Save or set, if set, then settings revert on cold boot > - Mode, 0-8 for regular modes (if supported), 10-12 for "warning" > styles > - Red, 0-255 > - Green, 0-255 > - Blue, 0-255 > - Speed, 0 = Slow, 1 = Medium, 2 = Fast > > /sys/devices/platform/asus-nb-wmi/tuf_krgb_state has the following > as input options via boolean "b b b b b": > - Save or set, if set, then settings revert on cold boot > - Boot, if true, the keyboard displays animation on boot > - Awake, if true, the keyboard LED's are on while device is awake > - Sleep, if true, the keyboard shows animation while device is > suspended > - Keybaord, appears to have no effect > > Signed-off-by: Luke D. Jones > --- > drivers/platform/x86/asus-wmi.c | 168 > +++++++++++++++++++++ > include/linux/platform_data/x86/asus-wmi.h | 6 + > 2 files changed, 174 insertions(+) > > diff --git a/drivers/platform/x86/asus-wmi.c > b/drivers/platform/x86/asus-wmi.c > index 62ce198a3463..09277bd98249 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -234,6 +234,9 @@ struct asus_wmi { > bool dgpu_disable_available; > bool dgpu_disable; > > + bool tuf_kb_rgb_mode_available; > + bool tuf_kb_rgb_state_available; > + > bool throttle_thermal_policy_available; > u8 throttle_thermal_policy_mode; > > @@ -734,6 +737,153 @@ static ssize_t egpu_enable_store(struct device > *dev, > > static DEVICE_ATTR_RW(egpu_enable); > > +/* TUF Laptop Keyboard RGB Modes > **********************************************/ > +static int tuf_kb_rgb_mode_check_present(struct asus_wmi *asus) > +{ > + u32 result; > + int err; > + > + asus->tuf_kb_rgb_mode_available = false; > + > + err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_TUF_RGB_MODE, > &result); > + if (err) { > + if (err == -ENODEV) > + return 0; > + return err; > + } > + > + if (result & ASUS_WMI_DSTS_PRESENCE_BIT) > + asus->tuf_kb_rgb_mode_available = true; > + > + return 0; > +} > + > +static ssize_t tuf_kb_rgb_mode_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + int err; > + u32 ret; > + u8 res, tmp, arg_num; > + char *data, *part, *end; > + u8 cmd, mode, r, g, b, speed; > + > + data = end = kstrdup(buf, GFP_KERNEL); > + cmd = mode = r = g = b = speed = arg_num = 0; > + > + while ((part = strsep(&end, " ")) != NULL) { > + if (part == NULL) > + return -1; > + > + res = kstrtou8(part, 10, &tmp); > + if (res) > + return -1; > + > + if (arg_num == 0) > + // apply : set > + cmd = tmp == 1 ? 0xb5 : 0xb4; > + else if (arg_num == 1) > + // From 0-8 are valid modes with 10-12 being "warning" > + // style modes. All models have "pulse" mode 10. > + mode = (tmp <= 12 && tmp != 9) ? tmp : 10; > + else if (arg_num == 2) > + r = tmp; > + else if (arg_num == 3) > + g = tmp; > + else if (arg_num == 4) > + b = tmp; > + else if (arg_num == 5) { > + if (tmp == 0) > + speed = 0xe1; > + else if (tmp == 1) > + speed = 0xeb; > + else if (tmp == 2) > + speed = 0xf5; > + } > + > + arg_num += 1; > + } > + > + err = asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, > ASUS_WMI_DEVID_TUF_RGB_MODE, > + cmd | (mode << 8) | (r << 16) | (g << 24), (b) | (speed << 8), > &ret); > + if (err) > + return err; > + > + kfree(data); > + return count; > +} > + > +static DEVICE_ATTR_WO(tuf_kb_rgb_mode); > + > +/* TUF Laptop Keyboard RGB States > *********************************************/ > +static int tuf_kb_rgb_state_check_present(struct asus_wmi *asus) > +{ > + u32 result; > + int err; > + > + asus->tuf_kb_rgb_state_available = false; > + > + err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_TUF_RGB_STATE, > &result); > + if (err) { > + if (err == -ENODEV) > + return 0; > + return err; > + } > + > + if (result & ASUS_WMI_DSTS_PRESENCE_BIT) > + asus->tuf_kb_rgb_state_available = true; > + > + return 0; > +} > + > +static ssize_t tuf_kb_rgb_state_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + int err; > + u32 ret; > + bool tmp; > + char *data, *part, *end; > + u8 save, flags, res, arg_num; > + > + save = flags = arg_num = 0; > + data = end = kstrdup(buf, GFP_KERNEL); > + > + while ((part = strsep(&end, " ")) != NULL) { > + if (part == NULL) > + return -1; > + > + res = kstrtobool(part, &tmp); > + if (res) > + return -1; > + > + if (tmp) { > + if (arg_num == 0) // save : set > + save = tmp == 0 ? 0x0100 : 0x0000; > + else if (arg_num == 1) > + flags |= 0x02; // boot > + else if (arg_num == 2) > + flags |= 0x08; // awake > + else if (arg_num == 3) > + flags |= 0x20; // sleep > + else if (arg_num == 4) > + flags |= 0x80; // keyboard > + } > + > + arg_num += 1; > + } > + > + err = asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, > + ASUS_WMI_DEVID_TUF_RGB_STATE, 0xBD | save | (flags << 16), 0, > &ret); > + if (err) > + return err; > + > + kfree(data); > + return count; > +} > + > +static DEVICE_ATTR_WO(tuf_kb_rgb_state); > + > /* Battery > ********************************************************************/ > > /* The battery maximum charging percentage */ > @@ -3258,6 +3408,8 @@ static struct attribute *platform_attributes[] > = { > &dev_attr_touchpad.attr, > &dev_attr_egpu_enable.attr, > &dev_attr_dgpu_disable.attr, > + &dev_attr_tuf_kb_rgb_mode.attr, > + &dev_attr_tuf_kb_rgb_state.attr, > &dev_attr_lid_resume.attr, > &dev_attr_als_enable.attr, > &dev_attr_fan_boost_mode.attr, > @@ -3286,6 +3438,12 @@ static umode_t asus_sysfs_is_visible(struct > kobject *kobj, > devid = ASUS_WMI_DEVID_ALS_ENABLE; > else if (attr == &dev_attr_egpu_enable.attr) > ok = asus->egpu_enable_available; > + else if (attr == &dev_attr_tuf_kb_rgb_mode.attr) > + ok = asus->tuf_kb_rgb_mode_available; > + else if (attr == &dev_attr_tuf_kb_rgb_state.attr) > + ok = asus->tuf_kb_rgb_state_available; > + else if (attr == &dev_attr_dgpu_disable.attr) > + ok = asus->dgpu_disable_available; > else if (attr == &dev_attr_dgpu_disable.attr) > ok = asus->dgpu_disable_available; > else if (attr == &dev_attr_fan_boost_mode.attr) > @@ -3557,6 +3715,14 @@ static int asus_wmi_add(struct platform_device > *pdev) > if (err) > goto fail_dgpu_disable; > > + err = tuf_kb_rgb_mode_check_present(asus); > + if (err) > + goto fail_tuf_kb_rgb_mode; > + > + err = tuf_kb_rgb_state_check_present(asus); > + if (err) > + goto fail_tuf_kb_rgb_state; > + > err = fan_boost_mode_check_present(asus); > if (err) > goto fail_fan_boost_mode; > @@ -3671,6 +3837,8 @@ static int asus_wmi_add(struct platform_device > *pdev) > fail_fan_boost_mode: > fail_egpu_enable: > fail_dgpu_disable: > +fail_tuf_kb_rgb_mode: > +fail_tuf_kb_rgb_state: > fail_platform: > fail_panel_od: > kfree(asus); > diff --git a/include/linux/platform_data/x86/asus-wmi.h > b/include/linux/platform_data/x86/asus-wmi.h > index a571b47ff362..af4191fb0508 100644 > --- a/include/linux/platform_data/x86/asus-wmi.h > +++ b/include/linux/platform_data/x86/asus-wmi.h > @@ -98,6 +98,12 @@ > /* dgpu on/off */ > #define ASUS_WMI_DEVID_DGPU 0x00090020 > > +/* TUF laptop RGB modes/colours */ > +#define ASUS_WMI_DEVID_TUF_RGB_MODE 0x00100056 > + > +/* TUF laptop RGB power/state */ > +#define ASUS_WMI_DEVID_TUF_RGB_STATE 0x00100057 > + > /* DSTS masks */ > #define ASUS_WMI_DSTS_STATUS_BIT 0x00000001 > #define ASUS_WMI_DSTS_UNKNOWN_BIT 0x00000002 > -- > 2.37.1 >