From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1EA6C4338F for ; Tue, 10 Aug 2021 13:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 893D060EE7 for ; Tue, 10 Aug 2021 13:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238701AbhHJN2J (ORCPT ); Tue, 10 Aug 2021 09:28:09 -0400 Received: from mga09.intel.com ([134.134.136.24]:16224 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235376AbhHJN2J (ORCPT ); Tue, 10 Aug 2021 09:28:09 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="214886544" X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="214886544" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 06:27:46 -0700 X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="506142307" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 06:27:42 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mDRn5-007PyS-SM; Tue, 10 Aug 2021 16:27:35 +0300 Date: Tue, 10 Aug 2021 16:27:35 +0300 From: Andy Shevchenko To: Kate Hsuan Cc: Mika Westerberg , Hans de Goede , Mark Gross , Alex Hung , Sujith Thomas , Rajneesh Bhardwaj , David E Box , Zha Qipeng , Srinivas Pandruvada , AceLan Kao , Jithu Joseph , Maurice Ma , Dan Carpenter , Daniel Scally , linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability. Message-ID: References: <20210810095832.4234-1-hpa@redhat.com> <20210810095832.4234-10-hpa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Tue, Aug 10, 2021 at 07:43:42PM +0800, Kate Hsuan wrote: > Hi Mika, > > Thanks for your suggestion. > I'll add them to the patches and resend them again. > > Thank you. Please, do not top post! > On Tue, Aug 10, 2021 at 6:06 PM Mika Westerberg > wrote: > > > > Hi, > > > > No objections, I think this is good idea but.. > > > > On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote: > > > > .. I suggest to add proper commit message here. Many maintainers ignore > > patches that don't have one. > > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%) > > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%) > > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%) > > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%) > > > rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%) Besides what Mika said this should follow the example of pmt, like dropping the intel_scu prefix from the files, but leave it for the module (see Makefile tricks for the details how to achieve this). -- With Best Regards, Andy Shevchenko