From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E038AC4338F for ; Tue, 10 Aug 2021 10:05:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF770601FD for ; Tue, 10 Aug 2021 10:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239674AbhHJKGQ (ORCPT ); Tue, 10 Aug 2021 06:06:16 -0400 Received: from mga07.intel.com ([134.134.136.100]:59569 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239669AbhHJKGP (ORCPT ); Tue, 10 Aug 2021 06:06:15 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="278619487" X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="278619487" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 03:05:53 -0700 X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="638755375" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 03:05:48 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 10 Aug 2021 13:05:45 +0300 Date: Tue, 10 Aug 2021 13:05:45 +0300 From: Mika Westerberg To: Kate Hsuan Cc: Hans de Goede , Mark Gross , Alex Hung , Sujith Thomas , Rajneesh Bhardwaj , David E Box , Zha Qipeng , Srinivas Pandruvada , AceLan Kao , Jithu Joseph , Maurice Ma , Andy Shevchenko , Dan Carpenter , Daniel Scally , linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability. Message-ID: References: <20210810095832.4234-1-hpa@redhat.com> <20210810095832.4234-10-hpa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210810095832.4234-10-hpa@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, No objections, I think this is good idea but.. On Tue, Aug 10, 2021 at 05:58:21PM +0800, Kate Hsuan wrote: .. I suggest to add proper commit message here. Many maintainers ignore patches that don't have one. > Signed-off-by: Kate Hsuan > --- > drivers/platform/x86/Kconfig | 47 ----------------- > drivers/platform/x86/Makefile | 6 +-- > drivers/platform/x86/intel/Kconfig | 1 + > drivers/platform/x86/intel/Makefile | 5 ++ > drivers/platform/x86/intel/scu/Kconfig | 52 +++++++++++++++++++ > drivers/platform/x86/intel/scu/Makefile | 11 ++++ > .../x86/{ => intel/scu}/intel_scu_ipc.c | 0 > .../x86/{ => intel/scu}/intel_scu_ipcutil.c | 0 > .../x86/{ => intel/scu}/intel_scu_pcidrv.c | 0 > .../x86/{ => intel/scu}/intel_scu_pltdrv.c | 0 > .../x86/{ => intel/scu}/intel_scu_wdt.c | 0 > 11 files changed, 70 insertions(+), 52 deletions(-) > create mode 100644 drivers/platform/x86/intel/scu/Kconfig > create mode 100644 drivers/platform/x86/intel/scu/Makefile > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%) > rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c (100%) > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c (100%) > rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c (100%) > rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)