From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEE4C4320A for ; Mon, 23 Aug 2021 09:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1068F613A3 for ; Mon, 23 Aug 2021 09:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236475AbhHWJe2 (ORCPT ); Mon, 23 Aug 2021 05:34:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:6662 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235980AbhHWJeL (ORCPT ); Mon, 23 Aug 2021 05:34:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="204265295" X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="204265295" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 02:33:26 -0700 X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="443386575" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 02:33:24 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mI6KU-00CjMZ-Se; Mon, 23 Aug 2021 12:33:18 +0300 Date: Mon, 23 Aug 2021 12:33:18 +0300 From: Andy Shevchenko To: Hans de Goede Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Piel , Mark Gross Subject: Re: [RFT, PATCH v1 1/1] platform/x86: hp_accel: Convert to be a platform driver Message-ID: References: <20210803200820.3259-1-andriy.shevchenko@linux.intel.com> <48332796-1b9a-c897-c695-e66b116386be@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48332796-1b9a-c897-c695-e66b116386be@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Fri, Aug 06, 2021 at 03:42:40PM +0200, Hans de Goede wrote: > Hi, > > On 8/3/21 10:08 PM, Andy Shevchenko wrote: > > ACPI core in conjunction with platform driver core provides > > an infrastructure to enumerate ACPI devices. Use it in order > > to remove a lot of boilerplate code. > > > > Signed-off-by: Andy Shevchenko > > --- > > > > Not sure what buys us to run _INI on PM calls. It's against the spec AFAICT. > > In any case ACPICA runs _INI as per specification when devices are > > instantiated. > > _INI used to also be ran on resume for some reason, but that was recently > changed. > > You're right that calling it is no longer necessary now that we no longer > do that. > > But the changes related to this are really separate from the platform > driver conversion, please split this into 2 patches. > > Also for the next version please Cc: Kai-Heng Feng > and ask him to test, I think he has access to hardware to test this. v2 has been sent. -- With Best Regards, Andy Shevchenko