[PATCH AUTOSEL 5.10 12/15] platform/x86: ISST: Increase range of valid mail box commands

[PATCH AUTOSEL 5.10 12/15] platform/x86: ISST: Increase range of valid mail box commands

[Sasha Levin]

From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

[ Upstream commit 95ecf90158522269749f1b7ce98b1eed66ca087b ]

A new command CONFIG_TDP_GET_RATIO_INFO is added, with sub command type
of 0x0C. The previous range of valid sub commands was from 0x00 to 0x0B.
Change the valid range from 0x00 to 0x0C.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://lore.kernel.org/r/20230227053504.2734214-1-srinivas.pandruvada@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/platform/x86/intel_speed_select_if/isst_if_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
index 407afafc7e83f..1effaa55092cc 100644
--- a/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
@@ -47,7 +47,7 @@ struct isst_cmd_set_req_type {
 
 static const struct isst_valid_cmd_ranges isst_valid_cmds[] = {
 	{0xD0, 0x00, 0x03},
-	{0x7F, 0x00, 0x0B},
+	{0x7F, 0x00, 0x0C},
 	{0x7F, 0x10, 0x12},
 	{0x7F, 0x20, 0x23},
 	{0x94, 0x03, 0x03},
-- 
2.39.2

Re: [PATCH AUTOSEL 5.10 12/15] platform/x86: ISST: Increase range of valid mail box commands

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

Hi!

> From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> 
> [ Upstream commit 95ecf90158522269749f1b7ce98b1eed66ca087b ]
> 
> A new command CONFIG_TDP_GET_RATIO_INFO is added, with sub command type
> of 0x0C. The previous range of valid sub commands was from 0x00 to 0x0B.
> Change the valid range from 0x00 to 0x0C.

Not sure why this was selected for stable.

We don't have CONFIG_TDP_GET_RATIO_INFO in 5.10, so we should not have
this.

Best regards,
								Pavel
								
> +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_common.c
> @@ -47,7 +47,7 @@ struct isst_cmd_set_req_type {
>  
>  static const struct isst_valid_cmd_ranges isst_valid_cmds[] = {
>  	{0xD0, 0x00, 0x03},
> -	{0x7F, 0x00, 0x0B},
> +	{0x7F, 0x00, 0x0C},
>  	{0x7F, 0x10, 0x12},
>  	{0x7F, 0x20, 0x23},
>  	{0x94, 0x03, 0x03},

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH AUTOSEL 5.10 12/15] platform/x86: ISST: Increase range of valid mail box commands

[Sasha Levin]

On Mon, Mar 20, 2023 at 02:50:28PM +0100, Pavel Machek wrote:
>Hi!
>
>> From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>>
>> [ Upstream commit 95ecf90158522269749f1b7ce98b1eed66ca087b ]
>>
>> A new command CONFIG_TDP_GET_RATIO_INFO is added, with sub command type
>> of 0x0C. The previous range of valid sub commands was from 0x00 to 0x0B.
>> Change the valid range from 0x00 to 0x0C.
>
>Not sure why this was selected for stable.
>
>We don't have CONFIG_TDP_GET_RATIO_INFO in 5.10, so we should not have
>this.

I'll drop it, thanks!

-- 
Thanks,
Sasha