From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DAF7C19F2A for ; Thu, 11 Aug 2022 15:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235020AbiHKPIO (ORCPT ); Thu, 11 Aug 2022 11:08:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234456AbiHKPIN (ORCPT ); Thu, 11 Aug 2022 11:08:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 009F0558CF for ; Thu, 11 Aug 2022 08:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660230492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z802gDpoJ9wWMBtv3NAnD9/R0f3Zm+XJ0jWpa2ZWjz4=; b=f9RbRgOYrew87E6HBvu+z5ZfQPZxtCTzYYH54SHgH9vecYWANr5U0pBqk2m9iD+cU53CIr rzckXLZjwJHm7iSINVb+y4w4NQzziJ+DiHiQCaYr39IQrIV67/tfUWtCsW0lMFcoDuSvGK HrbTP5LgULgr09e0vFi8hEe42KZ5Xvw= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-214-HTYZTnbLMh2yTb_ZFZhNBQ-1; Thu, 11 Aug 2022 11:08:10 -0400 X-MC-Unique: HTYZTnbLMh2yTb_ZFZhNBQ-1 Received: by mail-ej1-f71.google.com with SMTP id ho13-20020a1709070e8d00b00730a655e173so5578947ejc.8 for ; Thu, 11 Aug 2022 08:08:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=z802gDpoJ9wWMBtv3NAnD9/R0f3Zm+XJ0jWpa2ZWjz4=; b=teEz3m49uCzottnFevYv3jEu/dEn1HBAJKyyMs80NK26DIDDB7D0pzF9wyNe8cp6NW 3jdYHKr4sh4CwwAfwB2FfqFefFMrCjciWlxAr7t+NZYI9TRuxdlpGnKki72Ko3vR9fy+ Bl7l62+JwyDthnDslFhGcMFjP3zOW3hmIu7h5oQqHplb+6yM9FRs6xxxqCGlUS34Rg8n kocrWwotdLbO/5x/1O6LJJNofX10Snc7fChFGTG92iaXO+/RicXp7vFsvGIQ4TOfQSLs na0iFtPnB6ZqvKaouK2hTZvMsW1ajPAHunRNHN1TUZJzn6be4GvZ/N6lBdPhoPipTOAg jNEQ== X-Gm-Message-State: ACgBeo1uUz9iHB12Ww8fmM+7foPtfyh/T1REjZn81UZrXikWg1qJZM0z 2zR1NVY2C1Z7ulYeImiv7Oi6vLaYegIBvYDrvqi0qp0P0u0g1yv1FgGakzl9Qme84sDX/v6k/L7 xiha2fUsvgWlqtO80FIKthRmwEC6HtSR+tA== X-Received: by 2002:a17:907:9726:b0:730:9e04:f738 with SMTP id jg38-20020a170907972600b007309e04f738mr24358657ejc.631.1660230489317; Thu, 11 Aug 2022 08:08:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR4L0J8fiQyioAhT1n/XB5jHSFXJwxcpS4Eh7tCmUHQGsrOR6XP7hr5sKx6sUsGczluaPFs23g== X-Received: by 2002:a17:907:9726:b0:730:9e04:f738 with SMTP id jg38-20020a170907972600b007309e04f738mr24358646ejc.631.1660230489151; Thu, 11 Aug 2022 08:08:09 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id x24-20020a170906149800b00705cdfec71esm3629708ejc.7.2022.08.11.08.08.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Aug 2022 08:08:07 -0700 (PDT) Message-ID: Date: Thu, 11 Aug 2022 17:08:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 4/6] asus-wmi: Document previously added attributes Content-Language: en-US To: Andy Shevchenko , "Luke D. Jones" Cc: =?UTF-8?Q?Barnab=c3=a1s_P=c5=91cze?= , Pavel Machek , Platform Driver , Linux Kernel Mailing List References: <20220809025054.1626339-1-luke@ljones.dev> <20220809025054.1626339-5-luke@ljones.dev> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 8/9/22 11:25, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones wrote: >> >> Documents some previously added attributes: >> - dgpu_disable >> - egpu_enable >> - panel_od > > Try to find a commit that introduced thouse and add the respective Fixes tag. > > ... > >> - * keyboard - 0 or 1, unknown what effect this really has >> \ No newline at end of file >> + * keyboard - 0 or 1, unknown what effect this really has > > Should be part of another patch. Ack to both remarks. Luke please make this patch one of the first patches in your next version / patch-series and then add the doucmentation of the new kbd RGB backlight attributes in the patches where you are also adding those actual attributes. Regards, Hans