From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6D7C3F6B0 for ; Wed, 27 Jul 2022 02:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240121AbiG0C6Z (ORCPT ); Tue, 26 Jul 2022 22:58:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240141AbiG0C6Y (ORCPT ); Tue, 26 Jul 2022 22:58:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CE09371BE for ; Tue, 26 Jul 2022 19:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658890701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NwgcPcXk6z7kgNTCqH1DZ8dzrfHRERNfOmiystTGRCg=; b=eZydlh0X7GrW0nILFHvcYOiEACC1J63b31OTR4xtxiEDTwIZ6UDLsxq1UKBm1p9RP9V73T BtMw/P0x2Dmd8l6Qtf63igZtvYYYJwKB1HnBEbM5HVmUh6AQXjJlG2LIvHciKRALWw3JHt zZqdiYMpYxesLLXN0QqHfUqfhq9uTw8= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-T62Vr502P3-Wtbwxq4byTA-1; Tue, 26 Jul 2022 22:58:20 -0400 X-MC-Unique: T62Vr502P3-Wtbwxq4byTA-1 Received: by mail-pg1-f200.google.com with SMTP id g67-20020a636b46000000b0040e64eee874so7187053pgc.4 for ; Tue, 26 Jul 2022 19:58:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NwgcPcXk6z7kgNTCqH1DZ8dzrfHRERNfOmiystTGRCg=; b=Dk8O/ZLQG5TSM5N49++xTP6w0KiuPOhjPLtNak3UfdaNvCOULC7eP6rGYUKReZ76Jr /Md0YY4qOp7c76nnHYF4wBiSDRREr5PD+BpV94JNpAGPcEBCh12aORk6rF4F2cjoUz+7 YR41UO38zKxUCgF+Hhlov8QJ/t133MbGpehdtrKlfX63zTvknsh26huJ44TSIsOydxG6 +GcGkV9YYomayGfITHHSKArr8R2dOktl4DWD4C+YWooXLDnAdT1zdscIHiLBhu8JAizZ 25EHloUOQkAO9l2xGlgTIeWT6USkDdKwW8ysQh1YSmU1pN46xjKckkAgAojc1+hWRyCl 6cXg== X-Gm-Message-State: AJIora/y7OReh5M5OHXo9EDZIhS+py7C8zj4qIsDQHnGAn98+r9bw52X LzjS7Qaa1jG9u2t/GX2SuQqqCQVi5hcp+d5BdfMGaqKUE5qlfAqpieS8hhxbuXV+DSxfd18u9OH MdTPc0vAbZloezuIX/1hahpo8/RevBJv9Ng== X-Received: by 2002:a05:6a00:3498:b0:52a:f8f4:ca7c with SMTP id cp24-20020a056a00349800b0052af8f4ca7cmr20263316pfb.5.1658890699173; Tue, 26 Jul 2022 19:58:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uuhsCO0beWJTkbHykdBYq0Xbk9J6+h1S6RkU7roXWbxlzqfZMfKPxtL0BmhUqMmNTZjLJ/Gg== X-Received: by 2002:a05:6a00:3498:b0:52a:f8f4:ca7c with SMTP id cp24-20020a056a00349800b0052af8f4ca7cmr20263286pfb.5.1658890698768; Tue, 26 Jul 2022 19:58:18 -0700 (PDT) Received: from [10.72.13.38] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id u8-20020a1709026e0800b0016c29dcf1f7sm12230642plk.122.2022.07.26.19.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 19:58:18 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 10:58:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 07/42] virtio_ring: split: stop __vring_new_virtqueue as export symbol Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com References: <20220726072225.19884-1-xuanzhuo@linux.alibaba.com> <20220726072225.19884-8-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220726072225.19884-8-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org 在 2022/7/26 15:21, Xuan Zhuo 写道: > There is currently only one place to reference __vring_new_virtqueue() > directly from the outside of virtio core. And here vring_new_virtqueue() > can be used instead. > > Subsequent patches will modify __vring_new_virtqueue, so stop it as an > export symbol for now. > > Signed-off-by: Xuan Zhuo > --- > drivers/virtio/virtio_ring.c | 25 ++++++++++++++++--------- > include/linux/virtio_ring.h | 10 ---------- > tools/virtio/virtio_test.c | 4 ++-- > 3 files changed, 18 insertions(+), 21 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 0ad35eca0d39..4e54ed7ee7fb 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -204,6 +204,14 @@ struct vring_virtqueue { > #endif > }; > > +static struct virtqueue *__vring_new_virtqueue(unsigned int index, > + struct vring vring, > + struct virtio_device *vdev, > + bool weak_barriers, > + bool context, > + bool (*notify)(struct virtqueue *), > + void (*callback)(struct virtqueue *), > + const char *name); > > /* > * Helpers. > @@ -2197,14 +2205,14 @@ irqreturn_t vring_interrupt(int irq, void *_vq) > EXPORT_SYMBOL_GPL(vring_interrupt); > > /* Only available for split ring */ > -struct virtqueue *__vring_new_virtqueue(unsigned int index, > - struct vring vring, > - struct virtio_device *vdev, > - bool weak_barriers, > - bool context, > - bool (*notify)(struct virtqueue *), > - void (*callback)(struct virtqueue *), > - const char *name) > +static struct virtqueue *__vring_new_virtqueue(unsigned int index, > + struct vring vring, > + struct virtio_device *vdev, > + bool weak_barriers, > + bool context, > + bool (*notify)(struct virtqueue *), > + void (*callback)(struct virtqueue *), > + const char *name) > { > struct vring_virtqueue *vq; > > @@ -2272,7 +2280,6 @@ struct virtqueue *__vring_new_virtqueue(unsigned int index, > kfree(vq); > return NULL; > } > -EXPORT_SYMBOL_GPL(__vring_new_virtqueue); > > struct virtqueue *vring_create_virtqueue( > unsigned int index, > diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h > index b485b13fa50b..8b8af1a38991 100644 > --- a/include/linux/virtio_ring.h > +++ b/include/linux/virtio_ring.h > @@ -76,16 +76,6 @@ struct virtqueue *vring_create_virtqueue(unsigned int index, > void (*callback)(struct virtqueue *vq), > const char *name); > > -/* Creates a virtqueue with a custom layout. */ > -struct virtqueue *__vring_new_virtqueue(unsigned int index, > - struct vring vring, > - struct virtio_device *vdev, > - bool weak_barriers, > - bool ctx, > - bool (*notify)(struct virtqueue *), > - void (*callback)(struct virtqueue *), > - const char *name); > - > /* > * Creates a virtqueue with a standard layout but a caller-allocated > * ring. > diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c > index 23f142af544a..86a410ddcedd 100644 > --- a/tools/virtio/virtio_test.c > +++ b/tools/virtio/virtio_test.c > @@ -102,8 +102,8 @@ static void vq_reset(struct vq_info *info, int num, struct virtio_device *vdev) > > memset(info->ring, 0, vring_size(num, 4096)); > vring_init(&info->vring, num, info->ring, 4096); Let's remove the duplicated vring_init() here. With this removed: Acked-by: Jason Wang > - info->vq = __vring_new_virtqueue(info->idx, info->vring, vdev, true, > - false, vq_notify, vq_callback, "test"); > + info->vq = vring_new_virtqueue(info->idx, num, 4096, vdev, true, false, > + info->ring, vq_notify, vq_callback, "test"); > assert(info->vq); > info->vq->priv = info; > }