From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647C4C6FA83 for ; Mon, 12 Sep 2022 21:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiILV4d (ORCPT ); Mon, 12 Sep 2022 17:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbiILV42 (ORCPT ); Mon, 12 Sep 2022 17:56:28 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2DBC4DB19; Mon, 12 Sep 2022 14:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=qeScmlSI8Hi8VVYRvf9aNKdlS+V7Mh8b/pcQ1tMazl4=; b=h0TIXi8rk3Oq+o1oppxN9crjkW I6+Vy0ALGJv3j1R0EsfAgysvp9GJC0NXpqoh+4uyIyyscGZuw56P5cfq14tRXa6Fy04uPsbiotmR7 g3vZ/sl1+OsiYl32F0lPYvjvhZH6Z4pJPaPytub1uV0IjDFk+EageOIjDC3+Qq/aPISDnEaLZ0fIC pgR25ntwkSeL8ul/g47jKm342pdTw1C3vtmgiv7ULwodTPnh+SbQHTiQQ30Kcys+ofQwql2B5pGVA LEJk1740hi5XuHAnSCcJkPZrLVI0pcACUQbP+QTtZOYQwzdR/Xi0OTIJMzasxIxEUIXbaD1YcHue2 zXSP2PpQ==; Received: from [2601:1c0:6280:3f0::a6b3] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXrPY-00EPu2-Lx; Mon, 12 Sep 2022 21:56:13 +0000 Message-ID: Date: Mon, 12 Sep 2022 14:56:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 5/5] platform/x86: dell: Add new dell-wmi-ddv driver Content-Language: en-US To: Armin Wolf , hdegoede@redhat.com, markgross@kernel.org Cc: rafael@kernel.org, lenb@kernel.org, hmh@hmh.eng.br, matan@svgalib.org, corentin.chary@gmail.com, jeremy@system76.com, productdev@system76.com, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220912125342.7395-1-W_Armin@gmx.de> <20220912125342.7395-6-W_Armin@gmx.de> From: Randy Dunlap In-Reply-To: <20220912125342.7395-6-W_Armin@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi-- On 9/12/22 05:53, Armin Wolf wrote: > diff --git a/drivers/platform/x86/dell/Kconfig b/drivers/platform/x86/dell/Kconfig > index 25421e061c47..209e63e347e2 100644 > --- a/drivers/platform/x86/dell/Kconfig > +++ b/drivers/platform/x86/dell/Kconfig > @@ -189,6 +189,19 @@ config DELL_WMI_DESCRIPTOR > default n > depends on ACPI_WMI > > +config DELL_WMI_DDV > + tristate "Dell WMI sensors Support" > + default m You should (try to) justify default m, otherwise just don't have a default for it. > + depends on ACPI_BATTERY > + depends on ACPI_WMI > + help > + This option adds support for WMI-based sensors like > + battery temperature sensors found on some Dell notebooks. > + It also supports reading of the batteries ePPID. > + > + To compile this drivers as a module, choose M here: the module will > + be called dell-wmi-ddv. -- ~Randy