From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEFCDC19F28 for ; Wed, 27 Jul 2022 03:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240238AbiG0DPL (ORCPT ); Tue, 26 Jul 2022 23:15:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240194AbiG0DPI (ORCPT ); Tue, 26 Jul 2022 23:15:08 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5949CF3 for ; Tue, 26 Jul 2022 20:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658891705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yAKBMltJyGT+XDVzCIxs8bNeAmqSdQfBVMzuB9SWIpM=; b=ENXVBMTqrDiWz8UHE8gn6wA0SHc31fIcYxiBteg02M4UNFDQIGzLXmdrIa9KcYKGpM8Esf tuUsOYvqv8A183tZg7muvGGpX/Bne8uxZeZrnHf4XIkOU9IcAdHmPsru8a/DGMsHqWt8rI T6GFhhX0hvd/d2Zbp7iDOqyoVOZ77ig= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-567-oMHKnSCPOt-rhHnHEbKNGQ-1; Tue, 26 Jul 2022 23:15:04 -0400 X-MC-Unique: oMHKnSCPOt-rhHnHEbKNGQ-1 Received: by mail-pl1-f200.google.com with SMTP id z15-20020a170903018f00b0016d6e7a043dso4762242plg.12 for ; Tue, 26 Jul 2022 20:15:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yAKBMltJyGT+XDVzCIxs8bNeAmqSdQfBVMzuB9SWIpM=; b=VUp5CS3n4PiA0Xk5sydNmFbx4y9A2InhcDzAwjnchwjvB76zD1/UeGpumC1npSsYb6 W2GAsS4oYU5iKDPzfyXa4Qt8IXK4pi6lRtEb6mezpNiauvhvJUrdcLW/gUtXx0Uawe75 5dFpPwUGr++Nb3oVo7wTpQYuucynMIC1Jgso7QaiAhXqdXngN4u4g3VQXAUag75xTsRg kJD7WbeUyjC1kbXXv9sKLhgx4bqMcrObfVAqYoWOU1yk/hnVDyrGE3YIEOy9gzesb5EW 5pQcX0oWoJdzZo5KbI/pPj6zgElN3qGbTvIP68cK/sP4TfYsBUZPeGs+HC0HrPs5fCMq MYTg== X-Gm-Message-State: AJIora8zcQgpa6iRvC0iWxdwNeo5UZ1rnxWqzeMygjeYtNsrO3zJxisL /9xiYp9mcYzJplz+bbToYDW3a2DvJagKgfv7VCBZAy7fzV2sABzkdfLhq4Isu0NM88E1u1FPpve NPdcBlor7BhEgids6ZSU8tsspLmi8JE7ylQ== X-Received: by 2002:a17:90a:7ac4:b0:1ef:a606:4974 with SMTP id b4-20020a17090a7ac400b001efa6064974mr2213608pjl.51.1658891702482; Tue, 26 Jul 2022 20:15:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tidh/QksEFcBpkv4BftDUD29CxNpBLdCVexTNH/t5AotOLArf7ctQ7cPh2UR9oOEGuuBXIcw== X-Received: by 2002:a17:90a:7ac4:b0:1ef:a606:4974 with SMTP id b4-20020a17090a7ac400b001efa6064974mr2213573pjl.51.1658891702151; Tue, 26 Jul 2022 20:15:02 -0700 (PDT) Received: from [10.72.13.38] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id 2-20020a621902000000b005251fc16ff8sm12401220pfz.220.2022.07.26.20.14.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 20:15:01 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 11:14:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 10/42] virtio_ring: split: extract the logic of alloc queue Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com References: <20220726072225.19884-1-xuanzhuo@linux.alibaba.com> <20220726072225.19884-11-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220726072225.19884-11-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org 在 2022/7/26 15:21, Xuan Zhuo 写道: > Separate the logic of split to create vring queue. > > This feature is required for subsequent virtuqueue reset vring. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 65 ++++++++++++++++++++++-------------- > 1 file changed, 40 insertions(+), 25 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index ba7cc560d823..3817520371ee 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -958,29 +958,19 @@ static void vring_free_split(struct vring_virtqueue_split *vring_split, > kfree(vring_split->desc_extra); > } > > -static struct virtqueue *vring_create_virtqueue_split( > - unsigned int index, > - unsigned int num, > - unsigned int vring_align, > - struct virtio_device *vdev, > - bool weak_barriers, > - bool may_reduce_num, > - bool context, > - bool (*notify)(struct virtqueue *), > - void (*callback)(struct virtqueue *), > - const char *name) > +static int vring_alloc_queue_split(struct vring_virtqueue_split *vring_split, > + struct virtio_device *vdev, > + u32 num, > + unsigned int vring_align, > + bool may_reduce_num) > { > - struct vring_virtqueue_split vring_split = {}; > - struct virtqueue *vq; > void *queue = NULL; > dma_addr_t dma_addr; > - size_t queue_size_in_bytes; > - struct vring vring; > > /* We assume num is a power of 2. */ > if (num & (num - 1)) { > dev_warn(&vdev->dev, "Bad virtqueue length %u\n", num); > - return NULL; > + return -EINVAL; > } > > /* TODO: allocate each queue chunk individually */ > @@ -991,11 +981,11 @@ static struct virtqueue *vring_create_virtqueue_split( > if (queue) > break; > if (!may_reduce_num) > - return NULL; > + return -ENOMEM; > } > > if (!num) > - return NULL; > + return -ENOMEM; > > if (!queue) { > /* Try to get a single page. You are my only hope! */ > @@ -1003,21 +993,46 @@ static struct virtqueue *vring_create_virtqueue_split( > &dma_addr, GFP_KERNEL|__GFP_ZERO); > } > if (!queue) > - return NULL; > + return -ENOMEM; > + > + vring_init(&vring_split->vring, num, queue, vring_align); > > - queue_size_in_bytes = vring_size(num, vring_align); > - vring_init(&vring_split.vring, num, queue, vring_align); > + vring_split->queue_dma_addr = dma_addr; > + vring_split->queue_size_in_bytes = vring_size(num, vring_align); > + > + return 0; > +} > + > +static struct virtqueue *vring_create_virtqueue_split( > + unsigned int index, > + unsigned int num, > + unsigned int vring_align, > + struct virtio_device *vdev, > + bool weak_barriers, > + bool may_reduce_num, > + bool context, > + bool (*notify)(struct virtqueue *), > + void (*callback)(struct virtqueue *), > + const char *name) > +{ > + struct vring_virtqueue_split vring_split = {}; > + struct virtqueue *vq; > + int err; > + > + err = vring_alloc_queue_split(&vring_split, vdev, num, vring_align, > + may_reduce_num); > + if (err) > + return NULL; > > vq = __vring_new_virtqueue(index, &vring_split, vdev, weak_barriers, > context, notify, callback, name); > if (!vq) { > - vring_free_queue(vdev, queue_size_in_bytes, queue, > - dma_addr); > + vring_free_split(&vring_split, vdev); > return NULL; > } > > - to_vvq(vq)->split.queue_dma_addr = dma_addr; > - to_vvq(vq)->split.queue_size_in_bytes = queue_size_in_bytes; > + to_vvq(vq)->split.queue_dma_addr = vring_split.queue_dma_addr; > + to_vvq(vq)->split.queue_size_in_bytes = vring_split.queue_size_in_bytes; > to_vvq(vq)->we_own_ring = true; > > return vq;