From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mark Gross <mgross@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile
Date: Mon, 9 Aug 2021 11:00:17 +0200 [thread overview]
Message-ID: <bcd685c8-645e-eeff-6815-1251b28e1945@redhat.com> (raw)
In-Reply-To: <20210806154941.4491-1-andriy.shevchenko@linux.intel.com>
Hi,
On 8/6/21 5:49 PM, Andy Shevchenko wrote:
> The 'objs' is for user space tools, for the kernel modules
> we should use 'y'.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel/int33fe/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int33fe/Makefile b/drivers/platform/x86/intel/int33fe/Makefile
> index cc11183ce179..9456e3b37f6f 100644
> --- a/drivers/platform/x86/intel/int33fe/Makefile
> +++ b/drivers/platform/x86/intel/int33fe/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
> obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o
> -intel_cht_int33fe-objs := intel_cht_int33fe_common.o \
> +intel_cht_int33fe-y := intel_cht_int33fe_common.o \
> intel_cht_int33fe_typec.o \
> intel_cht_int33fe_microb.o
>
prev parent reply other threads:[~2021-08-09 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 15:49 [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile Andy Shevchenko
2021-08-09 9:00 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd685c8-645e-eeff-6815-1251b28e1945@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).