From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1422FC25B0D for ; Thu, 11 Aug 2022 18:53:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236086AbiHKSxW (ORCPT ); Thu, 11 Aug 2022 14:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236077AbiHKSxU (ORCPT ); Thu, 11 Aug 2022 14:53:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A39B9DFB8 for ; Thu, 11 Aug 2022 11:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660243998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNTgv0AuEhvVSuPncwI27XTWtpfQfISyWdWm6Vl1wMc=; b=HJVzC5S7H5JNyko6+2Cq9RROXXHYgkhI+a2fgwJGcOnL96jC5s9e3h/zGm9EUHKGN1r/Qn qm1uQgnayu/x5roje8cvc49uzKRw7aD+4cxGwC/HYcEaOq739RnN/HtrPR+MACmhc1182/ OZSd8+hb+5H0VpC9ne7w/d7wOggAZ0Q= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-413-Oxqwv8cGOtWrmVR5iYsmMA-1; Thu, 11 Aug 2022 14:53:15 -0400 X-MC-Unique: Oxqwv8cGOtWrmVR5iYsmMA-1 Received: by mail-ej1-f72.google.com with SMTP id sd6-20020a1709076e0600b0073315809fb5so1950934ejc.10 for ; Thu, 11 Aug 2022 11:53:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=mNTgv0AuEhvVSuPncwI27XTWtpfQfISyWdWm6Vl1wMc=; b=1YAPL6iIa83nemS5Iw1iL4w1jlukHzM7xLHHY8jYf8xaxZxb+6OELSQw0lXdIyoziq o5g/j1wvp5n2kJjmEUvNyFuQuo6z+zO5C8nTBTEh0i5emztn5JQG2O64kp9rq3EV00E6 6fR9TxE3fc5R4qL22Q9MyoUlXbr8v4gpsgPyfyY9De4QtXL2Z6sY83yP74P0R2NRIkNL XIJ6E49MgC9nMKWe9K5mqk5rcGTxkKBTrjlV4EMQSIsW8CsbMPAQGMyAGkteKEb+56Z5 ClIGW6b3FNTcp64nNO9EJqGCicAgS+fujVy2l2SkXxKG/KvNfbjvwCUmCufcTE7QyEu9 EsWw== X-Gm-Message-State: ACgBeo2oKDwafKyAIhEWm+ZzaR2FqO2ESB5yp/++Gwc1XNGIfpj55Xyf iG63Ape2qf21OGTBNDGLEGlgWeAwMIMW57NfAZSzSfnoiILhOjLsDMopZ3BW6mLxscuYmwTnchs RROSe7XhAZGRXgBCPNjdJ2/343VX8RNIOOg== X-Received: by 2002:a17:907:1361:b0:732:fefd:a25c with SMTP id yo1-20020a170907136100b00732fefda25cmr268497ejb.669.1660243994506; Thu, 11 Aug 2022 11:53:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR7zIuHWrgeUe2LwDJaqQZO56x+cUnpSgRZYkbLZ1QfdOCd0S4zbn7anXleqyoD8RYoiG4k3Yw== X-Received: by 2002:a17:907:1361:b0:732:fefd:a25c with SMTP id yo1-20020a170907136100b00732fefda25cmr268471ejb.669.1660243994295; Thu, 11 Aug 2022 11:53:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id me25-20020a170906aed900b007317f017e64sm3759882ejb.134.2022.08.11.11.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Aug 2022 11:53:13 -0700 (PDT) Message-ID: Date: Thu, 11 Aug 2022 20:53:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 4/4] platform/x86: simatic-ipc: enable watchdog for 227G Content-Language: en-US To: Henning Schild , Linus Walleij , Bartosz Golaszewski , Pavel Machek , Mark Gross , Andy Shevchenko , Lee Jones , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Sheng-Yuan Huang , Tasanakorn Phaipool , simon.guinot@sequanux.org References: <20220811153908.31283-1-henning.schild@siemens.com> <20220811153908.31283-5-henning.schild@siemens.com> From: Hans de Goede In-Reply-To: <20220811153908.31283-5-henning.schild@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 8/11/22 17:39, Henning Schild wrote: > Just load the watchdog module, after having identified that machine. > That watchdog module does not have any autoloading support. > > Signed-off-by: Henning Schild Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Patches which are added to review-hans now are intended for the next rc1. This branch will get rebased to the next rc1 when it is out and after the rebasing the contents of review-hans will be pushed to the platform-drivers-x86/for-next branch. Regards, Hans > --- > drivers/platform/x86/simatic-ipc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/x86/simatic-ipc.c b/drivers/platform/x86/simatic-ipc.c > index 1825ef21a86d..8dd686d1c9f1 100644 > --- a/drivers/platform/x86/simatic-ipc.c > +++ b/drivers/platform/x86/simatic-ipc.c > @@ -96,6 +96,9 @@ static int register_platform_devices(u32 station_id) > ipc_wdt_platform_device->name); > } > > + if (station_id == SIMATIC_IPC_IPC227G) > + request_module("w83627hf_wdt"); > + > if (ledmode == SIMATIC_IPC_DEVICE_NONE && > wdtmode == SIMATIC_IPC_DEVICE_NONE) { > pr_warn("unsupported IPC detected, station id=%08x\n",