* [PATCH] acer-wmi: use __packed instead of __attribute__((packed))
@ 2021-09-12 1:17 Jules Irenge
2021-09-13 13:37 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2021-09-12 1:17 UTC (permalink / raw)
To: jlee; +Cc: hdegoede, mgross, platform-driver-x86, linux-kernel, Jules Irenge
checkpatch.pl tool warns about using __attribute__((packed))
"WARNING: __packed is preferred over __attribute__((packed))"
To fix this __attribute__((packed)) is replaced by __packed
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/platform/x86/acer-wmi.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 694b45ed06a2..9c6943e401a6 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -138,7 +138,7 @@ struct event_return_value {
u16 reserved1;
u8 kbd_dock_state;
u8 reserved2;
-} __attribute__((packed));
+} __packed;
/*
* GUID3 Get Device Status device flags
@@ -172,33 +172,33 @@ struct func_input_params {
u8 app_status; /* Acer Device Status. LM, ePM, RF Button... */
u8 app_mask; /* Bit mask to app_status */
u8 reserved;
-} __attribute__((packed));
+} __packed;
struct func_return_value {
u8 error_code; /* Error Code */
u8 ec_return_value; /* EC Return Value */
u16 reserved;
-} __attribute__((packed));
+} __packed;
struct wmid3_gds_set_input_param { /* Set Device Status input parameter */
u8 function_num; /* Function Number */
u8 hotkey_number; /* Hotkey Number */
u16 devices; /* Set Device */
u8 volume_value; /* Volume Value */
-} __attribute__((packed));
+} __packed;
struct wmid3_gds_get_input_param { /* Get Device Status input parameter */
u8 function_num; /* Function Number */
u8 hotkey_number; /* Hotkey Number */
u16 devices; /* Get Device */
-} __attribute__((packed));
+} __packed;
struct wmid3_gds_return_value { /* Get Device Status return value*/
u8 error_code; /* Error Code */
u8 ec_return_value; /* EC Return Value */
u16 devices; /* Current Device Status */
u32 reserved;
-} __attribute__((packed));
+} __packed;
struct hotkey_function_type_aa {
u8 type;
@@ -210,7 +210,7 @@ struct hotkey_function_type_aa {
u16 display_func_bitmap;
u16 others_func_bitmap;
u8 commun_fn_key_number;
-} __attribute__((packed));
+} __packed;
/*
* Interface capability flags
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] acer-wmi: use __packed instead of __attribute__((packed))
2021-09-12 1:17 [PATCH] acer-wmi: use __packed instead of __attribute__((packed)) Jules Irenge
@ 2021-09-13 13:37 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-09-13 13:37 UTC (permalink / raw)
To: Jules Irenge, jlee; +Cc: mgross, platform-driver-x86, linux-kernel
Hi,
On 9/12/21 3:17 AM, Jules Irenge wrote:
> checkpatch.pl tool warns about using __attribute__((packed))
> "WARNING: __packed is preferred over __attribute__((packed))"
> To fix this __attribute__((packed)) is replaced by __packed
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/acer-wmi.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 694b45ed06a2..9c6943e401a6 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -138,7 +138,7 @@ struct event_return_value {
> u16 reserved1;
> u8 kbd_dock_state;
> u8 reserved2;
> -} __attribute__((packed));
> +} __packed;
>
> /*
> * GUID3 Get Device Status device flags
> @@ -172,33 +172,33 @@ struct func_input_params {
> u8 app_status; /* Acer Device Status. LM, ePM, RF Button... */
> u8 app_mask; /* Bit mask to app_status */
> u8 reserved;
> -} __attribute__((packed));
> +} __packed;
>
> struct func_return_value {
> u8 error_code; /* Error Code */
> u8 ec_return_value; /* EC Return Value */
> u16 reserved;
> -} __attribute__((packed));
> +} __packed;
>
> struct wmid3_gds_set_input_param { /* Set Device Status input parameter */
> u8 function_num; /* Function Number */
> u8 hotkey_number; /* Hotkey Number */
> u16 devices; /* Set Device */
> u8 volume_value; /* Volume Value */
> -} __attribute__((packed));
> +} __packed;
>
> struct wmid3_gds_get_input_param { /* Get Device Status input parameter */
> u8 function_num; /* Function Number */
> u8 hotkey_number; /* Hotkey Number */
> u16 devices; /* Get Device */
> -} __attribute__((packed));
> +} __packed;
>
> struct wmid3_gds_return_value { /* Get Device Status return value*/
> u8 error_code; /* Error Code */
> u8 ec_return_value; /* EC Return Value */
> u16 devices; /* Current Device Status */
> u32 reserved;
> -} __attribute__((packed));
> +} __packed;
>
> struct hotkey_function_type_aa {
> u8 type;
> @@ -210,7 +210,7 @@ struct hotkey_function_type_aa {
> u16 display_func_bitmap;
> u16 others_func_bitmap;
> u8 commun_fn_key_number;
> -} __attribute__((packed));
> +} __packed;
>
> /*
> * Interface capability flags
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-13 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12 1:17 [PATCH] acer-wmi: use __packed instead of __attribute__((packed)) Jules Irenge
2021-09-13 13:37 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).