From: Hans de Goede <hdegoede@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Andres Salomon <dilinger@queued.net>
Cc: Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Platform: OLPC: uninitialized data in debugfs write
Date: Thu, 28 Jul 2022 20:44:21 +0200 [thread overview]
Message-ID: <e365793f-02ff-9746-c03d-f2ed7127817a@redhat.com> (raw)
In-Reply-To: <YthIKn+TfZSZMEcM@kili>
Hi,
On 7/20/22 20:23, Dan Carpenter wrote:
> The call to:
>
> size = simple_write_to_buffer(cmdbuf, sizeof(cmdbuf), ppos, buf, size);
>
> will succeed if at least one byte is written to the "cmdbuf" buffer.
> The "*ppos" value controls which byte is written. Another problem is
> that this code does not check for errors so it's possible for the entire
> buffer to be unintialized.
>
> Inintialize the struct to zero to prevent reading uninitialized stack
> data.
>
> Debugfs is normally only writable by root so the impact of this bug is
> very minimal.
>
> Fixes: 6cca83d498bd ("Platform: OLPC: move debugfs support from x86 EC driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> The ec_dbgfs_cmd_write() function is not great. We could copy the data
> outside the lock for example. But that's outside the scope of this
> patch.
>
> drivers/platform/olpc/olpc-ec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c
> index 4ff5c3a12991..921520475ff6 100644
> --- a/drivers/platform/olpc/olpc-ec.c
> +++ b/drivers/platform/olpc/olpc-ec.c
> @@ -264,7 +264,7 @@ static ssize_t ec_dbgfs_cmd_write(struct file *file, const char __user *buf,
> int i, m;
> unsigned char ec_cmd[EC_MAX_CMD_ARGS];
> unsigned int ec_cmd_int[EC_MAX_CMD_ARGS];
> - char cmdbuf[64];
> + char cmdbuf[64] = "";
> int ec_cmd_bytes;
>
> mutex_lock(&ec_dbgfs_lock);
prev parent reply other threads:[~2022-07-28 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 18:23 [PATCH] Platform: OLPC: uninitialized data in debugfs write Dan Carpenter
2022-07-20 18:33 ` Dan Carpenter
2022-07-28 18:44 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e365793f-02ff-9746-c03d-f2ed7127817a@redhat.com \
--to=hdegoede@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dilinger@queued.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).