From: Hans de Goede <hdegoede@redhat.com>
To: Mark Pearson <markpearson@lenovo.com>,
Bastien Nocera <hadess@hadess.net>
Cc: dvhart@infradead.org, mgross@linux.intel.com,
mario.limonciello@dell.com, eliadevito@gmail.com,
bberg@redhat.com, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute
Date: Thu, 29 Oct 2020 10:46:38 +0100 [thread overview]
Message-ID: <ebeec472-3310-c560-e8bf-2b33c480333b@redhat.com> (raw)
In-Reply-To: <b3e61ee4-3fca-ce06-2216-977586baae4e@lenovo.com>
Hi,
On 10/29/20 1:55 AM, Mark Pearson wrote:
> Thanks Hans and Bastien,
>
> On 28/10/2020 13:23, Hans de Goede wrote:
<big snip>
>>> Is there another file which explains whether those sysfs value will
>>> contain a trailing linefeed?
>>
>> sysfs APIs are typically created so that they can be used from the shell,
>> so on read a newline will be added. On write a newline at the end
>> typically is allowed, but ignored. There are even special helper functions
>> to deal with properly ignoring the newline on write.
>>
>> Regards,
>>
>> Hans
>>
>>
> OK - does that need to actually be specified here? Or is that just something I keep in mind for the implementation?
IMHO it does not belong in the sysfs API docs for the platform_profile
stuff. But I guess it would be good to document it somewhere in some
generic syfs API rules/expectations document (with a note that their
might be exceptions).
Ideally we would already have such a file somewhere, but I don't know
if we do (I did not look). So if you feel like it (and such a file does
not exist yet) then I guess a patch adding such a doc file would be good.
Regards,
Hans
next prev parent reply other threads:[~2020-10-29 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 16:42 [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute Mark Pearson
2020-10-27 18:11 ` Elia Devito
2020-10-28 11:54 ` Hans de Goede
2020-10-28 13:45 ` Bastien Nocera
2020-10-28 17:23 ` Hans de Goede
2020-10-29 0:55 ` [External] " Mark Pearson
2020-10-29 9:46 ` Hans de Goede [this message]
2020-10-29 14:21 ` Bastien Nocera
2020-10-29 12:33 ` Bastien Nocera
2020-10-29 11:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebeec472-3310-c560-e8bf-2b33c480333b@redhat.com \
--to=hdegoede@redhat.com \
--cc=bberg@redhat.com \
--cc=dvhart@infradead.org \
--cc=eliadevito@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).