From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C02C433EF for ; Fri, 8 Jul 2022 13:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238239AbiGHNg6 (ORCPT ); Fri, 8 Jul 2022 09:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238057AbiGHNg5 (ORCPT ); Fri, 8 Jul 2022 09:36:57 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B8D1D312; Fri, 8 Jul 2022 06:36:57 -0700 (PDT) Received: from [192.168.2.145] (109-252-119-232.nat.spd-mgts.ru [109.252.119.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3EBC666019BD; Fri, 8 Jul 2022 14:36:55 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657287416; bh=uGsFBhHc9kJWk3WsIFFI61YBmGvbTRXKlcjd/9PjAq4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DS9pf2KztkBHA3zmK8czLuFCzxQkTopMbjqIMeSgl+9qwWFHDQzfAxnNcYNHERx6q cKlVmHGzJDJWXNmi6bOw1yQqCGiEbaTcVB5jp5rRZQJwzHhVRSTtnmQ55AJUBq0voh pQEnFcfAGvXpE98f3kCaPATOC9lCFqj7M+/NpRtmGQ5k9dtBkxVjXVQcl5wCLKHHi+ GFqqE6kYqFMuHIsJIxwv7VAssf6KYqUtZnFZaYHGH5Z6uJM6TMzWncpZrs19LoYIH8 Rz1HS6Si9Jg8wLwCnO6b7HOaEH+Y8xadUVEVhQMYXimM2j+0Ah235a6QZc8ivAuq8f VU1u/z4liIeJg== Message-ID: Date: Fri, 8 Jul 2022 16:36:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830/1050 poweroff again Content-Language: en-US To: Hans de Goede , "Rafael J . Wysocki" , Mika Westerberg , Mark Gross , Andy Shevchenko , Ard Biesheuvel Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-efi@vger.kernel.org References: <20220708131412.81078-1-hdegoede@redhat.com> <20220708131412.81078-2-hdegoede@redhat.com> From: Dmitry Osipenko In-Reply-To: <20220708131412.81078-2-hdegoede@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On 7/8/22 16:14, Hans de Goede wrote: > @@ -950,13 +953,19 @@ static int __init lenovo_yoga_tab2_830_1050_init(void) > if (ret) > return ret; > > - pm_power_off = lenovo_yoga_tab2_830_1050_power_off; > + /* SYS_OFF_PRIO_FIRMWARE + 1 so that it runs before acpi_power_off */ > + lenovo_yoga_tab2_830_1050_sys_off_handler = > + register_sys_off_handler(SYS_OFF_MODE_POWER_OFF, SYS_OFF_PRIO_FIRMWARE + 1, > + lenovo_yoga_tab2_830_1050_power_off, NULL); > + if (IS_ERR(lenovo_yoga_tab2_830_1050_sys_off_handler)) > + return PTR_ERR(lenovo_yoga_tab2_830_1050_sys_off_handler); Please note that technically we could ignore the registration error (maybe print error message) and allow the rest of the module to work without the power-off. The unregister_sys_off_handler() will skip the ERR_PTR handler. -- Best regards, Dmitry