From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62318C4338F for ; Wed, 18 Aug 2021 19:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D40160551 for ; Wed, 18 Aug 2021 19:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229965AbhHRT0S (ORCPT ); Wed, 18 Aug 2021 15:26:18 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]:38798 "EHLO mail-0201.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232676AbhHRT0P (ORCPT ); Wed, 18 Aug 2021 15:26:15 -0400 Date: Wed, 18 Aug 2021 19:25:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1629314736; bh=aWCsmwMyxCJOb9In9GRwiA+fRn6ttPi9bOrwWBDIw/g=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=dbTawmSQsBNAK/D8C7+bkqzfl9WexM/FCxkQnF4xH9XV5Dx9n2relLrzsskAjR/w7 fFFapM59in3qswxfaGxG3iII7qfJggDs24FNZo1jE28Tw72My4iSrY7yDNq8mpIEga 3xhCGxQaH4LVAIT17yZy3lYFrXcCnxOZ5J0FR97I= To: "Luke D. Jones" From: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: linux-kernel@vger.kernel.org, hdegoede@redhat.com, hadess@hadess.net, platform-driver-x86@vger.kernel.org Reply-To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Subject: Re: [PATCH v5 1/1] asus-wmi: Add support for platform_profile Message-ID: In-Reply-To: <20210818190731.19170-2-luke@ljones.dev> References: <20210818190731.19170-1-luke@ljones.dev> <20210818190731.19170-2-luke@ljones.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi 2021. augusztus 18., szerda 21:07 keltez=C3=A9ssel, Luke D. Jones =C3=ADrta= : > Add initial support for platform_profile where the support is > based on availability of ASUS_THROTTLE_THERMAL_POLICY. > > Because throttle_thermal_policy is used by platform_profile and is > writeable separately to platform_profile any userspace changes to > throttle_thermal_policy need to notify platform_profile. > > In future throttle_thermal_policy sysfs should be removed so that > only one method controls the laptop power profile. > > Signed-off-by: Luke D. Jones > --- > drivers/platform/x86/Kconfig | 1 + > drivers/platform/x86/asus-wmi.c | 130 +++++++++++++++++++++++++++++++- > 2 files changed, 127 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index d12db6c316ea..46dec48a36c1 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > [...] > +static int platform_profile_set(struct platform_profile_handler *pprof, > +=09=09=09=09enum platform_profile_option profile) > +{ > +=09struct asus_wmi *asus; > +=09int tp; > + > +=09asus =3D container_of(pprof, struct asus_wmi, platform_profile_handle= r); > + > +=09switch (profile) { > +=09case PLATFORM_PROFILE_PERFORMANCE: > +=09=09tp =3D ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST; > +=09=09break; > +=09case PLATFORM_PROFILE_BALANCED: > +=09=09tp =3D ASUS_THROTTLE_THERMAL_POLICY_DEFAULT; > +=09=09break; > +=09case PLATFORM_PROFILE_QUIET: > +=09=09tp =3D ASUS_THROTTLE_THERMAL_POLICY_SILENT; > +=09=09break; > +=09default: > +=09=09return -EOPNOTSUPP; > +=09} > + > +=09asus->throttle_thermal_policy_mode =3D tp; > +=09return throttle_thermal_policy_write(asus); Here the new mode will be stored even if activating it fails, no? > +} > [...] Best regards, Barnab=C3=A1s P=C5=91cze