From: Paolo Bonzini <pbonzini@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: eesposit@redhat.com, kwolf@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH 3/4] qemu-iotests: let "check" spawn an arbitrary test command
Date: Tue, 23 Mar 2021 18:22:21 +0100 [thread overview]
Message-ID: <0046f47b-6a46-6299-5816-44b7517a207a@redhat.com> (raw)
In-Reply-To: <b89670c6-153d-8434-da06-b212b887bc88@virtuozzo.com>
On 23/03/21 18:11, Vladimir Sementsov-Ogievskiy wrote:
>> If you have positional arguments that must begin with - and don’t look
>> like negative numbers, you can insert the pseudo-argument '--' which
>> tells parse_args() that everything after that is a positional argument:
>
> So, as I understand argparse supports '--' feature out of the box. So,
> we can keep '*' as is, and it would parse all remaining positional
> arguments which are either tests or the command, and '--' will be
> automatically dropped. So, we only need to check existing of '--' in
> original sys.argv to chose our behavior.
There is still a difference with REMAINDER:
./check aa -- bb
=> REMAINDER: error because ./-- is not a test
=> look for '--': invoke "aa -- bb"
So I think REMAINDER provides the best behavior overall.
Paolo
next prev parent reply other threads:[~2021-03-23 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:06 [PATCH 0/4] qemu-iotests: quality of life improvements Paolo Bonzini
2021-03-23 13:06 ` [PATCH 1/4] qemu-iotests: allow passing unittest.main arguments to the test scripts Paolo Bonzini
2021-03-23 14:34 ` Vladimir Sementsov-Ogievskiy
2021-03-23 15:29 ` Paolo Bonzini
2021-03-23 16:04 ` Vladimir Sementsov-Ogievskiy
2021-03-23 16:56 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:04 ` Paolo Bonzini
2021-03-23 17:27 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:35 ` Paolo Bonzini
2021-03-23 13:06 ` [PATCH 2/4] qemu-iotests: move command line and environment handling from TestRunner to TestEnv Paolo Bonzini
2021-03-23 16:22 ` Vladimir Sementsov-Ogievskiy
2021-03-23 13:06 ` [PATCH 3/4] qemu-iotests: let "check" spawn an arbitrary test command Paolo Bonzini
2021-03-23 16:43 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:00 ` Paolo Bonzini
2021-03-23 17:11 ` Vladimir Sementsov-Ogievskiy
2021-03-23 17:22 ` Paolo Bonzini [this message]
2021-03-23 17:39 ` Vladimir Sementsov-Ogievskiy
2021-03-23 13:06 ` [PATCH 4/4] qemu-iotests: fix case of SOCK_DIR already in the environment Paolo Bonzini
2021-03-23 16:45 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0046f47b-6a46-6299-5816-44b7517a207a@redhat.com \
--to=pbonzini@redhat.com \
--cc=eesposit@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).