From: Laurent Vivier <lvivier@redhat.com>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v4 0/2] net: tap: check file descriptor can be used
Date: Wed, 15 Jul 2020 11:16:35 +0200 [thread overview]
Message-ID: <01a66c39-0677-205c-120e-d7b4355efcdb@redhat.com> (raw)
In-Reply-To: <e4eb0b4a-aa07-0dfe-f6ca-3435b867df57@redhat.com>
On 09/07/2020 07:46, Jason Wang wrote:
>
> On 2020/7/8 上午2:45, Laurent Vivier wrote:
>> v4: use qemu_try_set_nonblock() with vhostfd in net_init_tap_one(),
>> and with fd in net_init_socket()
>>
>> v3: move qemu_fd_is_valid() checking into a new function
>> qemu_try_set_nonblock(), and use qemu_try_set_nonblock() in
>> qemu_set_nonblock().
>>
>> v2: Add patch from Daniel to check the fd can be used
>>
>> I have updated Daniel's patch not to check for EINVAL on TUNGETIFF
>> as I think we can avoid this special case because TUNGETIFF
>> is available since kernel v2.6.27 (October 2008)
>> Moreover I think the code was wrong as it was checking with
>> -EINVAL and
>> not EINVAL.
>>
>> Daniel P. Berrangé (1):
>> net: detect errors from probing vnet hdr flag for TAP devices
>>
>> Laurent Vivier (1):
>> net: check if the file descriptor is valid before using it
>>
>> include/qemu/sockets.h | 1 +
>> net/socket.c | 9 +++++--
>> net/tap-bsd.c | 2 +-
>> net/tap-linux.c | 8 +++---
>> net/tap-solaris.c | 2 +-
>> net/tap-stub.c | 2 +-
>> net/tap.c | 50 +++++++++++++++++++++++++++++-------
>> net/tap_int.h | 2 +-
>> util/oslib-posix.c | 26 +++++++++++++------
>> util/oslib-win32.c | 57 ++++++++++++++++++++++++------------------
>> 10 files changed, 108 insertions(+), 51 deletions(-)
>
>
> Applied.
It would have been great to have these fixes in 5.1
Thanks,
Laurent
next prev parent reply other threads:[~2020-07-15 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 18:45 [PATCH v4 0/2] net: tap: check file descriptor can be used Laurent Vivier
2020-07-07 18:45 ` [PATCH v4 1/2] net: check if the file descriptor is valid before using it Laurent Vivier
2020-07-07 18:45 ` [PATCH v4 2/2] net: detect errors from probing vnet hdr flag for TAP devices Laurent Vivier
2020-07-07 18:46 ` Philippe Mathieu-Daudé
2020-07-09 5:46 ` [PATCH v4 0/2] net: tap: check file descriptor can be used Jason Wang
2020-07-15 9:16 ` Laurent Vivier [this message]
2020-07-15 14:03 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a66c39-0677-205c-120e-d7b4355efcdb@redhat.com \
--to=lvivier@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).