From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB67DC4360C for ; Tue, 8 Oct 2019 18:24:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85ADC217D7 for ; Tue, 8 Oct 2019 18:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85ADC217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHu9v-0001nN-Lt for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 14:24:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35066) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHu8N-0000oX-Qp for qemu-devel@nongnu.org; Tue, 08 Oct 2019 14:22:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHu8M-0001QT-34 for qemu-devel@nongnu.org; Tue, 08 Oct 2019 14:22:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHu8L-0001Pf-TK for qemu-devel@nongnu.org; Tue, 08 Oct 2019 14:22:54 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBE9C3B714; Tue, 8 Oct 2019 18:22:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-109.rdu2.redhat.com [10.10.120.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E3C160BE0; Tue, 8 Oct 2019 18:22:46 +0000 (UTC) Subject: Re: [PATCH 2/4] target/i386: remove useless enable_compat_apic_id_mode() prototype To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu devel list References: <20191008105259.5378-1-lersek@redhat.com> <20191008105259.5378-3-lersek@redhat.com> From: Laszlo Ersek Message-ID: <032944de-23f7-53f9-27d1-ca0ce2321964@redhat.com> Date: Tue, 8 Oct 2019 20:22:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 08 Oct 2019 18:22:52 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , Paolo Bonzini , Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/08/19 15:35, Philippe Mathieu-Daud=C3=A9 wrote: > On 10/8/19 12:52 PM, Laszlo Ersek wrote: >> The enable_compat_apic_id_mode() function definition was removed earli= er; >=20 > "in 457cfcccdd1" Thanks. I'll add that to the commit message if I need to post a v2. >=20 >> there are no callers left. Remove the function declaration too. >> >> Cc: Eduardo Habkost >> Cc: Igor Mammedov >> Cc: Paolo Bonzini >> Cc: Richard Henderson >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1515 >> Signed-off-by: Laszlo Ersek >> --- >> =C2=A0 target/i386/cpu.h | 2 -- >> =C2=A0 1 file changed, 2 deletions(-) >> >> diff --git a/target/i386/cpu.h b/target/i386/cpu.h >> index eaa5395aa539..c9ab1a367939 100644 >> --- a/target/i386/cpu.h >> +++ b/target/i386/cpu.h >> @@ -2126,8 +2126,6 @@ void x86_cpu_set_default_version(X86CPUVersion >> version); >> =C2=A0 /* Return name of 32-bit register, from a R_* constant */ >> =C2=A0 const char *get_register_name_32(unsigned int reg); >> =C2=A0 -void enable_compat_apic_id_mode(void); >> - >> =C2=A0 #define APIC_DEFAULT_ADDRESS 0xfee00000 >> =C2=A0 #define APIC_SPACE_SIZE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0x100000 >> =C2=A0 >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 Cheers! Laszlo