From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEC5C07E95 for ; Fri, 16 Jul 2021 16:35:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F8C3613CF for ; Fri, 16 Jul 2021 16:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F8C3613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4Qo6-0005b0-5x for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 12:35:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4Qmz-0004M7-DU for qemu-devel@nongnu.org; Fri, 16 Jul 2021 12:34:13 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:45903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4Qmx-0007we-TH for qemu-devel@nongnu.org; Fri, 16 Jul 2021 12:34:13 -0400 Received: by mail-pg1-x52e.google.com with SMTP id y17so10436658pgf.12 for ; Fri, 16 Jul 2021 09:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=rP2/KXHrABUuOZ7Gry2VPqvnsBK5X6S+2R+W1T6Z0o0=; b=GQnXchg5a0C2+9YfIV5znMVPiUQPxmvsCN5a7glhY6UJBM7FzxctQg3msA5JVjHxya 5LvQZ+9NJILgXE2juhrDWWAGiC3VBg947SjpR5qEfeJj7d/75asOMdFQ6oyHuHkQ9nNU F3XL3cfekmD6tI/Y8U0JprMDI5xe+1+M9idb2PaenPhM+93iLxfY+jFM9AlRcPlCq3d/ AvxXAGgVJekrYBE+NnJaY66ZqVtRuqVs0hFCajNXGpRISFMzuvIWUQX06nvrizHPbEsx zvhjU4eg9SBvViA+I99VgpoJt4W876faZkL0Smn6Y3jZc9pfROThpM0oqN5QbDVFYdr8 9r7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rP2/KXHrABUuOZ7Gry2VPqvnsBK5X6S+2R+W1T6Z0o0=; b=ZOsgMM7i9eBGh5rqxyOZOUlxlI4FGA263WmvKnAbOjKcE5XdI8gWbj5+M0TCjp3Jrh BBjMKLuEELSM5P1oYY1HMWOs4Jh7JU+hLjxVepyKE8OtKJ68Y/mQ8bjqV7+6hmRiFDHq ZnWLd3hxWZ0xd3ODWfrYXX5jgIGslE66/T128gCMaP7628mO/DVicFO4c4KxQZNKRArG AGGvNTvIvrqQA5r32cIUA2TSBOwSYUGvA2nnABd5USA0woAMSVH/NJT2oD6xIRkpF8zG Y9NuyCr6PNzB9Eqb9RirLwGOtv9vQj1oqqfnM4rQNcShh89gdqa2ZfxTrtMVbDoe9mjO ONtg== X-Gm-Message-State: AOAM532CpffpM2LdRQ1khu04MzSeAtva47F+gAzl/5+VPuVUOFa1oCu/ 40wbUuGcq85I7e7+J4eSUdrixbttmoiRpA== X-Google-Smtp-Source: ABdhPJx6L9Qlgn4Qq9qIcEljBJizGgtplnHC9pqpNlVoE1Zgjy8/KjJb1xaD7ksjykCYbIW0qa3hPw== X-Received: by 2002:a63:5442:: with SMTP id e2mr10951706pgm.365.1626453250325; Fri, 16 Jul 2021 09:34:10 -0700 (PDT) Received: from [192.168.1.11] ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id v10sm12561668pjd.29.2021.07.16.09.34.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jul 2021 09:34:10 -0700 (PDT) Subject: Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210713133726.26842-1-peter.maydell@linaro.org> <20210713133726.26842-7-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <0332b682-1bd0-ca64-65f6-e06e1ad9c0bb@linaro.org> Date: Fri, 16 Jul 2021 09:34:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713133726.26842-7-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/13/21 6:36 AM, Peter Maydell wrote: > - return (1ULL << 47) - (src >= 0); > + return sextract64((1ULL << 47) - (src >= 0), 0, 48); Clearer as return src >= 0 ? MAKE_64BIT_MASK(0, 47) : MAKE_64BIT_MASK(47, 17); ? Otherwise, Reviewed-by: Richard Henderson r~