From: fengzhimin <fengzhimin1@huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Zhanghailiang <zhang.zhanghailiang@huawei.com>,
"quintela@redhat.com" <quintela@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"jemmy858585@gmail.com" <jemmy858585@gmail.com>
Subject: RE: [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter
Date: Wed, 15 Jan 2020 01:57:01 +0000 [thread overview]
Message-ID: <03C2A65461456D4EBE9E6D4D0D96C583FBC7CE@DGGEMI529-MBX.china.huawei.com> (raw)
In-Reply-To: <87v9pfwesp.fsf@dusky.pond.sub.org>
Thanks for your review. I will fix these errors in the next version(V2).
-----Original Message-----
From: Markus Armbruster [mailto:armbru@redhat.com]
Sent: Monday, January 13, 2020 11:35 PM
To: fengzhimin <fengzhimin1@huawei.com>
Cc: quintela@redhat.com; dgilbert@redhat.com; eblake@redhat.com; jemmy858585@gmail.com; qemu-devel@nongnu.org; Zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter
Zhimin Feng <fengzhimin1@huawei.com> writes:
> From: fengzhimin <fengzhimin1@huawei.com>
>
> Indicates the number of RDMA threads that we would create.
> By default we create 2 threads for RDMA migration.
>
> Signed-off-by: fengzhimin <fengzhimin1@huawei.com>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json index
> c995ffdc4c..ab79bf0600 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -588,6 +588,10 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # Defaults to 99. (Since 3.1)
> #
> +# @multi-rdma-channels: Number of channels used to migrate data in
> +# parallel. This is the same number that the
same number as
> +# number of multiRDMA used for migration. The
Pardon my ignorance: what's "the number of multiRDMA used for migration"?
> +# default value is 2 (since 4.2)
(since 5.0)
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
> @@ -600,7 +604,8 @@
> 'downtime-limit', 'x-checkpoint-delay', 'block-incremental',
> 'multifd-channels',
> 'xbzrle-cache-size', 'max-postcopy-bandwidth',
> - 'max-cpu-throttle' ] }
> + 'max-cpu-throttle',
> + 'multi-rdma-channels'] }
>
> ##
> # @MigrateSetParameters:
> @@ -690,6 +695,10 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # The default value is 99. (Since 3.1)
> #
> +# @multi-rdma-channels: Number of channels used to migrate data in
> +# parallel. This is the same number that the
> +# number of multiRDMA used for migration. The
> +# default value is 2 (since 4.2)
See above.
> # Since: 2.4
> ##
> # TODO either fuse back into MigrationParameters, or make @@ -715,7
> +724,8 @@
> '*multifd-channels': 'int',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle': 'int' } }
> + '*max-cpu-throttle': 'int',
Please use spaces instead of tab.
> + '*multi-rdma-channels': 'int'} }
>
> ##
> # @migrate-set-parameters:
> @@ -825,6 +835,10 @@
> # Defaults to 99.
> # (Since 3.1)
> #
> +# @multi-rdma-channels: Number of channels used to migrate data in
> +# parallel. This is the same number that the
> +# number of multiRDMA used for migration. The
> +# default value is 2 (since 4.2)
> # Since: 2.4
See above.
> ##
> { 'struct': 'MigrationParameters',
> @@ -847,8 +861,9 @@
> '*block-incremental': 'bool' ,
> '*multifd-channels': 'uint8',
> '*xbzrle-cache-size': 'size',
> - '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle':'uint8'} }
> + '*max-postcopy-bandwidth': 'size',
> + '*max-cpu-throttle':'uint8',
> + '*multi-rdma-channels':'uint8'} }
>
> ##
> # @query-migrate-parameters:
Please use spaces instead of tab.
next prev parent reply other threads:[~2020-01-15 1:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 4:59 [PATCH RFC 00/12] *** mulitple RDMA channels for migration *** Zhimin Feng
2020-01-09 4:59 ` [PATCH RFC 01/12] migration: Add multiRDMA capability support Zhimin Feng
2020-01-13 15:30 ` Markus Armbruster
2020-01-15 1:55 ` fengzhimin
2020-01-13 16:26 ` Eric Blake
2020-01-15 2:04 ` fengzhimin
2020-01-15 18:09 ` Dr. David Alan Gilbert
2020-01-16 13:18 ` Juan Quintela
2020-01-17 1:30 ` fengzhimin
2020-01-09 4:59 ` [PATCH RFC 02/12] migration: Export the 'migration_incoming_setup' function and add the 'migrate_use_rdma_pin_all' function Zhimin Feng
2020-01-15 18:57 ` Dr. David Alan Gilbert
2020-01-16 13:19 ` Juan Quintela
2020-01-09 4:59 ` [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter Zhimin Feng
2020-01-13 15:34 ` Markus Armbruster
2020-01-15 1:57 ` fengzhimin [this message]
2020-01-16 13:20 ` Juan Quintela
2020-01-09 4:59 ` [PATCH RFC 04/12] migration/rdma: Create multiRDMA migration threads Zhimin Feng
2020-01-16 13:25 ` Juan Quintela
2020-01-17 1:32 ` fengzhimin
2020-01-09 4:59 ` [PATCH RFC 05/12] migration/rdma: Create the multiRDMA channels Zhimin Feng
2020-01-15 19:54 ` Dr. David Alan Gilbert
2020-01-16 13:30 ` Juan Quintela
2020-01-09 4:59 ` [PATCH RFC 06/12] migration/rdma: Transmit initial package Zhimin Feng
2020-01-15 18:36 ` Dr. David Alan Gilbert
2020-01-09 4:59 ` [PATCH RFC 07/12] migration/rdma: Be sure all channels are created Zhimin Feng
2020-01-09 4:59 ` [PATCH RFC 08/12] migration/rdma: register memory for multiRDMA channels Zhimin Feng
2020-01-09 4:59 ` [PATCH RFC 09/12] migration/rdma: Wait for all multiRDMA to complete registration Zhimin Feng
2020-01-09 4:59 ` [PATCH RFC 10/12] migration/rdma: use multiRDMA to send RAM block for rdma-pin-all mode Zhimin Feng
2020-01-09 4:59 ` [PATCH RFC 11/12] migration/rdma: use multiRDMA to send RAM block for NOT " Zhimin Feng
2020-01-09 4:59 ` [PATCH RFC 12/12] migration/rdma: only register the virt-ram block for MultiRDMA Zhimin Feng
2020-01-17 18:52 ` Dr. David Alan Gilbert
2020-01-19 1:44 ` fengzhimin
2020-01-20 9:05 ` Dr. David Alan Gilbert
2020-01-21 1:30 ` fengzhimin
2020-01-09 10:38 ` [PATCH RFC 00/12] *** mulitple RDMA channels for migration *** no-reply
2020-01-15 19:57 ` Dr. David Alan Gilbert
2020-01-16 1:37 ` fengzhimin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03C2A65461456D4EBE9E6D4D0D96C583FBC7CE@DGGEMI529-MBX.china.huawei.com \
--to=fengzhimin1@huawei.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jemmy858585@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).