From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Claudio Fontana" <cfontana@suse.de>,
"Igor Mammedov" <imammedo@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v26 00/20] i386 cleanup PART 2
Date: Wed, 5 May 2021 14:15:29 +0200 [thread overview]
Message-ID: <03b6b51e-71d7-a2c9-4d3d-db1ac77a1484@redhat.com> (raw)
In-Reply-To: <87o8dpo4ww.fsf@linaro.org>
On 5/5/21 12:04 PM, Alex Bennée wrote:
> Claudio Fontana <cfontana@suse.de> writes:
>> On 3/8/21 3:02 PM, Alex Bennée wrote:
>>> Claudio Fontana <cfontana@suse.de> writes:
>>>
>>>> Hi,
>>>>
>>>> anything else for me to do here?
>>>
>>> It looks to me that this series is looking pretty good. Every patch has
>>> at least one review so I think it's just waiting on the maintainers to
>>> pick it up.
>>>
>>> Paolo/Richard - are you intending to take the series as is or are you
>>> waiting for something else? I'd like to see the patch delta reduced for
>>> the ARM cleanup work which is still ongoing.
>>
>> I am a bit at a loss here, as this has been reviewed for a while, but nothing is happening.
>> Rebasing is starting to become more and more draining;
>
> This is still the latest re-factor right?
>
> Subject: [PATCH v28 00/23] i386 cleanup PART 2
> Date: Mon, 22 Mar 2021 14:27:36 +0100
> Message-Id: <20210322132800.7470-1-cfontana@suse.de>
>
>> I am seeing some changes from Phil that redo some of the patches here (like target arch user),
>> maybe you would like to drive this?
>
> AIUI his changes where to get qtest passing.
I hadn't read Claudio's mail, I think he's mentioning commit 46369b50ee3
meson: Introduce meson_user_arch source set for arch-specific user-mode
Similarly to the 'target_softmmu_arch' source set which allows
to restrict target-specific sources to system emulation, add
the equivalent 'target_user_arch' set for user emulation.
The patch only contains 6 lines in 2 hunks, if it introduced a conflict
it should be trivial to resolve (I wasn't expecting it to conflict with
your work when I merged it TBH).
> I've just been chatting to
> Paolo on IRC so I think we are almost ready to go.
>
> > bonzini_: what's currently holding up getting Claudio's re-factoring
> work merged?
> > f4bug: also ^ - I'm a little worried we have splintering
> re-factoring forks
> *** First activity: f4bug joined 2 hours 8 minutes 6 seconds ago.
> <f4bug> stsquad: the qtests series is pending imammedo review then
> could go in
> <f4bug> stsquad: which would simplify a bit Claudio's series (on
> respin he could drop a pair of patches)
> <f4bug> stsquad: my understanding was bonzini_ would merge the x86
> series, then pm215 could merge the arm one on top
> *** First activity: bonzini_ joined 1 hour 17 minutes 25 seconds ago.
> <bonzini_> ok i can queue it in my next PR
> <f4bug> the only blocking part is qtest not passing, but Claudio's
> refactor series is not the culprit
> <bonzini_> ok
I was referring to:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg804015.html
Then these aren't required:
- tests: restrict TCG-only arm-cpu-features tests to TCG builds
- tests: device-introspect-test: cope with ARM TCG-only devices
These could be reworked to use qtest_has_accel() instead of the
/* XXX */ comments:
- tests: do not run test-hmp on all machines for ARM KVM-only
- tests: do not run qom-test on all machines for ARM KVM-only
I didn't noticed the following patch had its content changed:
Revert "target/arm: Restrict v8M IDAU to TCG"
So now this is not a full revert, only the TYPE_IDAU_INTERFACE
type is moved back.
While this fixes the build, we still have a QOM design problem.
QOM interfaces can't be Kconfig-selected out. <- Eduardo, Markus?
More generally I think more code should be automatically stripped
out by Kconfig instead. In [1,2] I suggested to tie accel-specific
Kconfig selectors:
config ARM_V7R
bool
depends on TCG && ARM
config ARM_V7M
bool
depends on TCG && ARM
select PTIMER
config XLNX_ZYNQMP_ARM
bool
default y if TCG && AARCH64
But this can certainly be done on top of Claudio's work.
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg777710.html
[2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg777719.html
next prev parent reply other threads:[~2021-05-05 12:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 8:54 [PATCH v26 00/20] i386 cleanup PART 2 Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 01/20] target/i386: Rename helper_fldt, helper_fstt Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 02/20] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 03/20] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 04/20] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 05/20] accel: introduce new accessor functions Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 06/20] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 07/20] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 08/20] meson: add target_user_arch Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 09/20] i386: split off sysemu-only functionality in tcg-cpu Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 10/20] i386: split smm helper (sysemu) Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 11/20] i386: split tcg excp_helper into sysemu and user parts Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 12/20] i386: move TCG bpt_helper into sysemu/ Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 13/20] i386: split misc helper user stubs and sysemu part Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 14/20] i386: separate fpu_helper sysemu-only parts Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 15/20] i386: split svm_helper into sysemu and stub-only user Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 16/20] i386: split seg_helper into user-only and sysemu parts Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 17/20] i386: split off sysemu part of cpu.c Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 18/20] target/i386: gdbstub: introduce aux functions to read/write CS64 regs Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 19/20] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu Claudio Fontana
2021-03-01 8:54 ` [PATCH v26 20/20] i386: make cpu_load_efer sysemu-only Claudio Fontana
2021-03-01 9:18 ` [PATCH v26 00/20] i386 cleanup PART 2 no-reply
2021-03-08 12:57 ` Claudio Fontana
2021-03-08 13:27 ` Philippe Mathieu-Daudé
2021-03-08 13:52 ` Claudio Fontana
2021-03-08 14:57 ` Philippe Mathieu-Daudé
2021-03-08 15:03 ` Claudio Fontana
2021-03-08 15:07 ` Daniel P. Berrangé
2021-03-08 14:02 ` Alex Bennée
2021-05-05 8:27 ` Claudio Fontana
2021-05-05 10:04 ` Alex Bennée
2021-05-05 12:15 ` Philippe Mathieu-Daudé [this message]
2021-05-05 12:24 ` Philippe Mathieu-Daudé
2021-05-05 19:31 ` Eduardo Habkost
2021-05-06 7:55 ` Claudio Fontana
2021-05-06 9:10 ` Philippe Mathieu-Daudé
2021-05-06 9:33 ` Philippe Mathieu-Daudé
2021-05-12 7:17 ` Philippe Mathieu-Daudé
2021-05-17 6:17 ` Claudio Fontana
2021-05-19 18:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03b6b51e-71d7-a2c9-4d3d-db1ac77a1484@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).