Re: [PULL 0/4] Trivial branch patches

[Laurent Vivier <laurent@vivier.eu>]

Le 05/11/2019 à 17:03, Dr. David Alan Gilbert a écrit :
> * Laurent Vivier (laurent@vivier.eu) wrote:
>> Greg, Dave,
>>
>> could you fix that?
>>
>> Thanks,
>> Laurent
>>
>> Le 05/11/2019 à 16:48, no-reply@patchew.org a écrit :
>>> Patchew URL: https://patchew.org/QEMU/20191105144247.10301-1-laurent@vivier.eu/
>>>
>>>
>>>
>>> Hi,
>>>
>>> This series seems to have some coding style problems. See output below for
>>> more information:
>>>
>>> Subject: [PULL 0/4] Trivial branch patches
>>> Type: series
>>> Message-id: 20191105144247.10301-1-laurent@vivier.eu
>>>
>>> === TEST SCRIPT BEGIN ===
>>> #!/bin/bash
>>> git rev-parse base > /dev/null || exit 0
>>> git config --local diff.renamelimit 0
>>> git config --local diff.renames True
>>> git config --local diff.algorithm histogram
>>> ./scripts/checkpatch.pl --mailback base..
>>> === TEST SCRIPT END ===
>>>
>>> Switched to a new branch 'test'
>>> 85ac453 global: Squash 'the the'
>>> 9dd7da4 qom: Fix error message in object_class_property_add()
>>> 2b76b45 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses
>>> bddcfd9 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers
>>>
>>> === OUTPUT BEGIN ===
>>> 1/4 Checking commit bddcfd9b6b24 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers)
>>> 2/4 Checking commit 2b76b451f9b7 (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses)
>>> 3/4 Checking commit 9dd7da421bfb (qom: Fix error message in object_class_property_add())
>>> WARNING: line over 80 characters
>>> #31: FILE: qom/object.c:1109:
>>> +        error_setg(errp, "attempt to add duplicate property '%s' to object (type '%s')",
>>>
>>> WARNING: line over 80 characters
>>> #43: FILE: qom/object.c:1141:
>>> +        error_setg(errp, "attempt to add duplicate property '%s' to class (type '%s')",
>>>
>>> total: 0 errors, 2 warnings, 22 lines checked
>>>
>>> Patch 3/4 has style problems, please review.  If any of these errors
>>> are false positives report them to the maintainer, see
>>> CHECKPATCH in MAINTAINERS.
>>> 4/4 Checking commit 85ac453d1520 (global: Squash 'the the')
>>> ERROR: do not use C99 // comments
>>> #26: FILE: disas/libvixl/vixl/invalset.h:105:
>>> +  // Note that this does not mean the backing storage is empty: it can still
> 
> That one is a false positive; libvixl is written in C++ !

OK, thank you.

Laurent