From: Eric DeVolder <eric.devolder@oracle.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, mst@redhat.com, konrad.wilk@oracle.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
boris.ostrovsky@oracle.com, rth@twiddle.net
Subject: Re: [PATCH v6 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2
Date: Mon, 4 Oct 2021 15:37:32 -0500 [thread overview]
Message-ID: <04de2ac5-3b6f-6340-0d47-1635ebf66eb2@oracle.com> (raw)
In-Reply-To: <20210920150507.17110ed1@redhat.com>
On 9/20/21 8:05 AM, Igor Mammedov wrote:
> On Thu, 5 Aug 2021 18:30:30 -0400
> Eric DeVolder <eric.devolder@oracle.com> wrote:
>
>> Following the guidelines in tests/qtest/bios-tables-test.c, this
>> change adds empty placeholder files per step 1 for the new ERST
>> table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
>> per step 2.
>>
>
> I'd move this right before 10/10
done
>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
>
>
>> ---
>> tests/data/acpi/microvm/ERST | 0
>> tests/data/acpi/pc/ERST | 0
>> tests/data/acpi/q35/ERST | 0
>> tests/qtest/bios-tables-test-allowed-diff.h | 6 ++++++
>> 4 files changed, 6 insertions(+)
>> create mode 100644 tests/data/acpi/microvm/ERST
>> create mode 100644 tests/data/acpi/pc/ERST
>> create mode 100644 tests/data/acpi/q35/ERST
>>
>> diff --git a/tests/data/acpi/microvm/ERST b/tests/data/acpi/microvm/ERST
>> new file mode 100644
>> index 0000000..e69de29
>> diff --git a/tests/data/acpi/pc/ERST b/tests/data/acpi/pc/ERST
>> new file mode 100644
>> index 0000000..e69de29
>> diff --git a/tests/data/acpi/q35/ERST b/tests/data/acpi/q35/ERST
>> new file mode 100644
>> index 0000000..e69de29
>> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
>> index dfb8523..b3aaf76 100644
>> --- a/tests/qtest/bios-tables-test-allowed-diff.h
>> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
>> @@ -1 +1,7 @@
>> /* List of comma-separated changed AML files to ignore */
>> +"tests/data/acpi/pc/ERST",
>> +"tests/data/acpi/q35/ERST",
>> +"tests/data/acpi/microvm/ERST",
>> +"tests/data/acpi/pc/DSDT",
>> +"tests/data/acpi/q35/DSDT",
>> +"tests/data/acpi/microvm/DSDT",
>
next prev parent reply other threads:[~2021-10-04 20:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 22:30 [PATCH v6 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2 Eric DeVolder
2021-09-20 13:05 ` Igor Mammedov
2021-10-04 20:37 ` Eric DeVolder [this message]
2021-08-05 22:30 ` [PATCH v6 02/10] ACPI ERST: specification for ERST support Eric DeVolder
2021-09-20 13:38 ` Igor Mammedov
2021-10-04 20:40 ` Eric DeVolder
2021-10-06 6:58 ` [PATCH] " Ani Sinha
2021-10-06 7:00 ` Ani Sinha
2021-10-06 20:07 ` Eric DeVolder
2021-10-07 4:39 ` Ani Sinha
2021-10-06 8:12 ` [PATCH v6 02/10] " Michael S. Tsirkin
2021-10-06 20:07 ` Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 03/10] ACPI ERST: PCI device_id for ERST Eric DeVolder
2021-09-21 11:32 ` Igor Mammedov
2021-08-05 22:30 ` [PATCH v6 04/10] ACPI ERST: header file " Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 05/10] ACPI ERST: support for ACPI ERST feature Eric DeVolder
2021-09-21 15:30 ` Igor Mammedov
2021-10-04 21:13 ` Eric DeVolder
2021-10-05 11:39 ` Igor Mammedov
2021-10-05 16:40 ` Eric DeVolder
2021-10-06 14:36 ` Igor Mammedov
2021-08-05 22:30 ` [PATCH v6 06/10] ACPI ERST: build the ACPI ERST table Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 07/10] ACPI ERST: create ACPI ERST table for pc/x86 machines Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 08/10] ACPI ERST: qtest for ERST Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 09/10] ACPI ERST: bios-tables-test testcase Eric DeVolder
2021-09-21 11:32 ` Igor Mammedov
2021-10-04 21:13 ` Eric DeVolder
2021-08-05 22:30 ` [PATCH v6 10/10] ACPI ERST: step 6 of bios-tables-test Eric DeVolder
2021-08-06 17:16 ` Eric DeVolder
2021-08-27 21:45 ` Eric DeVolder
2021-09-02 6:34 ` Igor Mammedov
2021-09-21 11:24 ` Igor Mammedov
2021-10-04 21:14 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04de2ac5-3b6f-6340-0d47-1635ebf66eb2@oracle.com \
--to=eric.devolder@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).