From: Thomas Huth <thuth@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/8] iotests: Add -display none to the qemu options
Date: Tue, 20 Aug 2019 08:36:37 +0200 [thread overview]
Message-ID: <0612e3e5-2787-7726-63d9-43693fc09e30@redhat.com> (raw)
In-Reply-To: <20190819201851.24418-2-mreitz@redhat.com>
On 8/19/19 10:18 PM, Max Reitz wrote:
> Without this argument, qemu will print an angry message about not being
> able to connect to a display server if $DISPLAY is not set. For me,
> that breaks iotests.supported_formats() because it thus only sees
> ["Could", "not", "connect"] as the supported formats.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/qemu-iotests/check | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index c24874ff4a..a58232eefb 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -581,13 +581,13 @@ export QEMU_PROG="$(type -p "$QEMU_PROG")"
>
> case "$QEMU_PROG" in
> *qemu-system-arm|*qemu-system-aarch64)
> - export QEMU_OPTIONS="-nodefaults -machine virt,accel=qtest"
> + export QEMU_OPTIONS="-nodefaults -display none -machine virt,accel=qtest"
> ;;
> *qemu-system-tricore)
> - export QEMU_OPTIONS="-nodefaults -machine tricore_testboard,accel=qtest"
> + export QEMU_OPTIONS="-nodefaults -display none -machine tricore_testboard,accel=qtest"
> ;;
> *)
> - export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
> + export QEMU_OPTIONS="-nodefaults -display none -machine accel=qtest"
> ;;
> esac
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-08-20 6:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 20:18 [Qemu-devel] [PATCH v3 0/8] iotests: Selfish patches Max Reitz
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 1/8] iotests: Add -display none to the qemu options Max Reitz
2019-08-20 6:36 ` Thomas Huth [this message]
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio Max Reitz
2019-08-19 20:22 ` Max Reitz
2019-08-20 21:05 ` John Snow
2019-08-20 6:38 ` Thomas Huth
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 3/8] iotests: Allow skipping test cases Max Reitz
2019-08-20 21:17 ` John Snow
2019-08-21 17:39 ` Andrey Shinkevich
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 4/8] iotests: Use case_skip() in skip_if_unsupported() Max Reitz
2019-08-20 21:27 ` John Snow
2019-08-21 10:50 ` Max Reitz
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 5/8] iotests: Let skip_if_unsupported() accept a method Max Reitz
2019-08-20 21:31 ` John Snow
2019-08-21 10:54 ` Max Reitz
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093 Max Reitz
2019-08-20 6:40 ` Thomas Huth
2019-08-20 12:23 ` Max Reitz
2019-08-20 21:32 ` John Snow
2019-08-21 10:55 ` Max Reitz
2019-09-13 12:47 ` Max Reitz
2019-09-13 18:30 ` John Snow
2019-09-17 8:18 ` Max Reitz
2019-09-17 8:29 ` Max Reitz
2019-09-17 8:32 ` Max Reitz
2019-09-17 8:40 ` Kevin Wolf
2019-09-17 11:07 ` Max Reitz
2019-09-17 11:22 ` Kevin Wolf
2019-09-17 13:09 ` John Snow
2019-09-17 13:42 ` Kevin Wolf
2019-09-17 13:44 ` John Snow
2019-09-17 14:05 ` Kevin Wolf
2019-09-17 14:12 ` Max Reitz
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 7/8] iotests: Test driver whitelisting in 136 Max Reitz
2019-08-19 20:18 ` [Qemu-devel] [PATCH v3 8/8] iotests: Cache supported_formats() Max Reitz
2019-08-20 21:10 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0612e3e5-2787-7726-63d9-43693fc09e30@redhat.com \
--to=thuth@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).