From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: Cleber Rosa <crosa@redhat.com>, qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
"Fabien Chouteau" <chouteau@adacore.com>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Willian Rampazzo" <wrampazz@redhat.com>,
qemu-ppc@nongnu.org,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH
Date: Thu, 7 Nov 2019 17:46:13 -0200 [thread overview]
Message-ID: <0660a16e-2ffc-fd3f-bfc7-cb0c43f1aef9@redhat.com> (raw)
In-Reply-To: <20191104151323.9883-7-crosa@redhat.com>
On 11/4/19 1:13 PM, Cleber Rosa wrote:
> So that when binaries such as qemu-img are searched for, those in the
> build tree will be favored. As a clarification, SRC_ROOT_DIR is
> dependent on the location from where tests are executed, so they are
> equal to the build directory if one is being used.
>
> The original motivation is that Avocado libraries such as
> avocado.utils.vmimage.get() may use the matching binaries, but it may
> also apply to any other binary that test code may eventually attempt
> to execute.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> index 17ce583c87..a4bb796a47 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -110,6 +110,12 @@ class Test(avocado.Test):
> return None
>
> def setUp(self):
> + # Some utility code uses binaries from the system's PATH. For
> + # instance, avocado.utils.vmimage.get() uses qemu-img, to
> + # create a snapshot image. This is a transparent way of
Because PATH is changed in a transparent way, wouldn't be better to also
self.log.info() that fact?
> + # making sure those utilities find and use binaries on the
> + # build tree by default.
> + os.environ['PATH'] = '%s:%s' % (SRC_ROOT_DIR, os.environ['PATH'])
I think PATH should be set only once at class initialization. Perhaps in
setUpClass()?
- Wainer
> self._vms = {}
>
> self.arch = self.params.get('arch',
next prev parent reply other threads:[~2019-11-07 19:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 15:13 [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 1/8] Acceptance test x86_cpu_model_versions: use default vm Cleber Rosa
2019-11-04 18:22 ` Philippe Mathieu-Daudé
2019-11-04 15:13 ` [PATCH v7 2/8] Acceptance tests: introduce utility method for tags unique vals Cleber Rosa
2019-11-08 13:14 ` Philippe Mathieu-Daudé
2019-11-11 21:44 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type Cleber Rosa
2019-11-08 13:20 ` Philippe Mathieu-Daudé
2019-11-11 21:49 ` Cleber Rosa
2019-11-12 18:15 ` Philippe Mathieu-Daudé
2019-11-12 1:59 ` Cleber Rosa
2019-11-12 18:15 ` Philippe Mathieu-Daudé
2019-11-04 15:13 ` [PATCH v7 4/8] Acceptance tests: use relative location for tests Cleber Rosa
2019-11-04 18:26 ` Philippe Mathieu-Daudé
2019-11-11 22:11 ` Cleber Rosa
2019-11-12 18:17 ` Philippe Mathieu-Daudé
2019-11-07 18:52 ` Wainer dos Santos Moschetta
2019-11-04 15:13 ` [PATCH v7 5/8] Acceptance tests: keep a stable reference to the QEMU build dir Cleber Rosa
2019-11-07 19:22 ` Wainer dos Santos Moschetta
2019-11-11 22:38 ` Cleber Rosa
2019-11-15 21:36 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH Cleber Rosa
2019-11-07 19:46 ` Wainer dos Santos Moschetta [this message]
2019-11-11 22:49 ` Cleber Rosa
2019-11-12 14:00 ` Wainer dos Santos Moschetta
2019-11-15 23:17 ` Cleber Rosa
2019-11-08 13:13 ` Philippe Mathieu-Daudé
2019-11-15 23:19 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 7/8] Acceptance tests: depend on qemu-img Cleber Rosa
2019-11-07 20:31 ` Wainer dos Santos Moschetta
2019-11-15 23:45 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 8/8] Acceptance test: add "boot_linux" tests Cleber Rosa
2019-11-08 19:42 ` Wainer dos Santos Moschetta
2019-11-15 23:47 ` Cleber Rosa
2019-11-12 18:20 ` Philippe Mathieu-Daudé
2019-11-15 23:48 ` Cleber Rosa
2019-12-03 19:19 ` Alex Bennée
2019-11-04 19:54 ` [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test no-reply
2019-11-07 18:38 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0660a16e-2ffc-fd3f-bfc7-cb0c43f1aef9@redhat.com \
--to=wainersm@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=bleal@redhat.com \
--cc=chouteau@adacore.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).