QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Helge Deller <deller@gmx.de>
To: Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v2 0/4] target-hppa fixes
Date: Sat, 1 Aug 2020 19:26:00 +0200
Message-ID: <066e9cd1-9a69-7302-3d8f-0800455b67a7@gmx.de> (raw)
In-Reply-To: <21ec077f-b3aa-b755-7191-fc12985714bc@msgid.tls.msk.ru>

Hi Michael,

On 01.08.20 18:47, Michael Tokarev wrote:
> 01.08.2020 16:13, Helge Deller wrote:
>> A few late fixes for target-hppa:
>>
>> * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian
>
> It looks like you forgot the above change somehow.

Actually, no, I did not forgot this patch.
It's part of the seabios-hppa repo, see here:
https://github.com/hdeller/seabios-hppa/commit/14a26ffb0d9ad1fc510da5d03215b0e36f717fce

In this qemu patch series the binary firmware-hppa.img blob I
sent was built with it.

> And me too,
> I forgot to send you a proper [PATCH] for this.  This is what
> I use in Debian:
>
> From: Michael Tokarev <mjt@tls.msk.ru>
> Subject: seabios-hppa: add -fno-ipa-sra to the compiler flags
> Date: Wed, 22 Jul 2020 22:15:46 +0300
>
> This allows seabios-hppa to build with gcc-10. Or else the
> compiler generates eg memset.isra.0 symbols instead of memset,
> and the final link step fails due to missing memset.
>
> Previous versions of gcc, for quite some time already, recognizes
> this option but it does nothing since apparently no-ipa-sra is the
> default. So there's no harm in adding it unconditionally, it seems.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>
> index c0d5d958..1b7757e8 100644
> --- a/Makefile.parisc
> +++ b/Makefile.parisc
> @@ -76 +76 @@ COMMONCFLAGS := -I$(OUT) -Isrc -Ivgasrc -Os -MD -g \
> -    -fno-builtin-printf
> +    -fno-builtin-printf -fno-ipa-sra
>
>
> This should not be required for the actual binary once it is built,
> however.

Yep.

Thanks!
Helge


  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01 13:13 Helge Deller
2020-08-01 13:13 ` [PATCH v2 1/4] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources Helge Deller
2020-08-01 13:13 ` [PATCH v2 2/4] seabios-hppa: Update to SeaBIOS hppa version 1 Helge Deller
2020-08-01 13:13 ` [PATCH v2 3/4] hw/hppa: Implement proper SeaBIOS version check Helge Deller
2020-08-01 13:13 ` [PATCH v2 4/4] hw/display/artist.c: fix out of bounds check Helge Deller
2020-08-03 15:55   ` Richard Henderson
2020-08-03 17:36   ` Alexander Bulekov
2020-08-03 18:32     ` Alexander Bulekov
2020-08-03 19:10       ` Alexander Bulekov
2020-08-03 20:43         ` Helge Deller
2020-08-01 16:47 ` [PATCH v2 0/4] target-hppa fixes Michael Tokarev
2020-08-01 17:26   ` Helge Deller [this message]
2020-08-01 17:50     ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=066e9cd1-9a69-7302-3d8f-0800455b67a7@gmx.de \
    --to=deller@gmx.de \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git