From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSmaF-0006Tr-FN for qemu-devel@nongnu.org; Mon, 08 Feb 2016 09:14:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSmaA-0004UQ-Va for qemu-devel@nongnu.org; Mon, 08 Feb 2016 09:14:31 -0500 From: Alberto Garcia Date: Mon, 8 Feb 2016 16:14:05 +0200 Message-Id: <07c19103660708d7b728f9521686b07c7a021645.1454940776.git.berto@igalia.com> In-Reply-To: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> References: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> In-Reply-To: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> References: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> Subject: [Qemu-devel] [PATCH 3/3] block: Update the x-blockdev-del documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Explain what happens if the user tries to delete a BlockBackend that contains media that was added separately using blockdev-add. Signed-off-by: Alberto Garcia --- qapi/block-core.json | 5 ++++- qmp-commands.hx | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 33012b8..cc59ab9 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2089,7 +2089,10 @@ # # In the former case the backend will be destroyed, along with its # inserted medium if there's any. The command will fail if the backend -# or its medium are in use. +# or its medium are in use. If the medium was also created with +# blockdev-add then the command will succeed, the backend will be +# destroyed but the medium will remain until it is deleted with +# x-blockdev-del. # # In the latter case the node will be destroyed. The command will fail # if the node is attached to a block backend or is otherwise being diff --git a/qmp-commands.hx b/qmp-commands.hx index 020e5ee..9710686 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -4151,7 +4151,10 @@ The selected device can be either a block backend or a graph node. In the former case the backend will be destroyed, along with its inserted medium if there's any. The command will fail if the backend -or its medium are in use. +or its medium are in use. If the medium was also created with +blockdev-add then the command will succeed, the backend will be +destroyed but the medium will remain until it is deleted with +x-blockdev-del. In the latter case the node will be destroyed. The command will fail if the node is attached to a block backend or is otherwise being -- 2.7.0