From: Jason Wang <jasowang@redhat.com>
To: Zhang Chen <chen.zhang@intel.com>,
qemu-dev <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: Zhang Chen <zhangckid@gmail.com>
Subject: Re: [PATCH 1/3] qapi/net: Add new QMP command for COLO passthrough
Date: Fri, 25 Dec 2020 14:20:07 +0800 [thread overview]
Message-ID: <08fe5c51-1383-12dd-b255-151a868cd6d9@redhat.com> (raw)
In-Reply-To: <20201224010918.19275-2-chen.zhang@intel.com>
On 2020/12/24 上午9:09, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Since the real user scenario does not need to monitor all traffic.
> Add colo-passthrough-add and colo-passthrough-del to maintain
> a COLO network passthrough list.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
> net/net.c | 12 ++++++++++++
> qapi/net.json | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 58 insertions(+)
>
> diff --git a/net/net.c b/net/net.c
> index e1035f21d1..eac7a92618 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1151,6 +1151,18 @@ void qmp_netdev_del(const char *id, Error **errp)
> qemu_del_net_client(nc);
> }
>
> +void qmp_colo_passthrough_add(const char *prot, const uint32_t port,
> + Error **errp)
> +{
> + /* Setup passthrough connection */
> +}
> +
> +void qmp_colo_passthrough_del(const char *prot, const uint32_t port,
> + Error **errp)
> +{
> + /* Delete passthrough connection */
> +}
> +
> static void netfilter_print_info(Monitor *mon, NetFilterState *nf)
> {
> char *str;
> diff --git a/qapi/net.json b/qapi/net.json
> index c31748c87f..466c29714e 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -714,3 +714,49 @@
> ##
> { 'event': 'FAILOVER_NEGOTIATED',
> 'data': {'device-id': 'str'} }
> +
> +##
> +# @colo-passthrough-add:
> +#
> +# Add passthrough entry according to customer's needs in COLO-compare.
> +#
> +# @protocol: COLO passthrough just support TCP and UDP.
> +#
> +# @port: TCP or UDP port number.
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 5.3
> +#
> +# Example:
> +#
> +# -> { "execute": "colo-passthrough-add",
> +# "arguments": { "protocol": "tcp", "port": 3389 } }
> +# <- { "return": {} }
> +#
> +##
> +{ 'command': 'colo-passthrough-add',
> + 'data': {'protocol': 'str', 'port': 'uint32'} }
Do we plan to support 4-tuple (src ip,src port, dst ip, dst port) in the
future? If yes, let's add them now.
And do we plan to support wildcard here?
Thanks
> +
> +##
> +# @colo-passthrough-del:
> +#
> +# Delete passthrough entry according to customer's needs in COLO-compare.
> +#
> +# @protocol: COLO passthrough just support TCP and UDP.
> +#
> +# @port: TCP or UDP port number.
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 5.3
> +#
> +# Example:
> +#
> +# -> { "execute": "colo-passthrough-del",
> +# "arguments": { "protocol": "tcp", "port": 3389 } }
> +# <- { "return": {} }
> +#
> +##
> +{ 'command': 'colo-passthrough-del',
> + 'data': {'protocol': 'str', 'port': 'uint32'} }
next prev parent reply other threads:[~2020-12-25 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 1:09 [PATCH 0/3] Bypass specific network traffic in COLO Zhang Chen
2020-12-24 1:09 ` [PATCH 1/3] qapi/net: Add new QMP command for COLO passthrough Zhang Chen
2020-12-25 6:20 ` Jason Wang [this message]
2020-12-28 0:38 ` Zhang, Chen
2020-12-28 7:11 ` Jason Wang
2020-12-29 2:56 ` Zhang, Chen
2020-12-30 3:56 ` Jason Wang
2021-01-05 3:28 ` Zhang, Chen
2021-01-05 4:17 ` Jason Wang
2021-01-05 6:29 ` Zhang, Chen
2021-01-19 19:32 ` Eric Blake
2021-01-21 1:50 ` Zhang, Chen
2020-12-24 1:09 ` [PATCH 2/3] hmp-commands: Add new HMP " Zhang Chen
2020-12-24 1:09 ` [PATCH 3/3] net/colo-compare: Add handler for passthrough connection Zhang Chen
2021-01-14 13:45 ` Lukas Straub
2021-01-15 9:07 ` Zhang, Chen
2021-01-15 16:06 ` Lukas Straub
2021-01-14 13:50 ` Lukas Straub
2021-01-15 9:08 ` Zhang, Chen
2020-12-25 6:23 ` [PATCH 0/3] Bypass specific network traffic in COLO Jason Wang
2020-12-28 0:38 ` Zhang, Chen
2021-01-04 13:06 ` Dr. David Alan Gilbert
2021-01-05 3:28 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08fe5c51-1383-12dd-b255-151a868cd6d9@redhat.com \
--to=jasowang@redhat.com \
--cc=armbru@redhat.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).