QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Tony Nguyen <tony.nguyen@bt.com>
To: qemu-devel@nongnu.org
Cc: Tony Nguyen <tony.nguyen@bt.com>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [RFC PATCH 11/17] hw/misc: Declare device little or big endian
Date: Sat, 24 Aug 2019 04:56:32 +1000
Message-ID: <094d765fcaa42b40328186129628b188b2b93477.1566467963.git.tony.nguyen@bt.com> (raw)
In-Reply-To: <cover.1566467963.git.tony.nguyen@bt.com>

For each device declared with DEVICE_NATIVE_ENDIAN, find the set of
targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare
the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN
respectively.

This *naive* deduction may result in genuinely native endian devices
being incorrectly declared as little or big endian, but should not
introduce regressions for current targets.

These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it
has a new target with an opposite endian or 2) someone informed knows
better =)

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
---
 hw/misc/a9scu.c    | 2 +-
 hw/misc/applesmc.c | 6 +++---
 hw/misc/arm11scu.c | 2 +-
 hw/misc/arm_l2x0.c | 2 +-
 hw/misc/puv3_pm.c  | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu.c
index 45c91db303..59335ca72f 100644
--- a/hw/misc/a9scu.c
+++ b/hw/misc/a9scu.c
@@ -96,7 +96,7 @@ static void a9_scu_write(void *opaque, hwaddr offset,
 static const MemoryRegionOps a9_scu_ops = {
     .read = a9_scu_read,
     .write = a9_scu_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
 };
 
 static void a9_scu_reset(DeviceState *dev)
diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index 24d57e8677..fb39837b7f 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -285,7 +285,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
 static const MemoryRegionOps applesmc_data_io_ops = {
     .write = applesmc_io_data_write,
     .read = applesmc_io_data_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
@@ -295,7 +295,7 @@ static const MemoryRegionOps applesmc_data_io_ops = {
 static const MemoryRegionOps applesmc_cmd_io_ops = {
     .write = applesmc_io_cmd_write,
     .read = applesmc_io_cmd_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
@@ -305,7 +305,7 @@ static const MemoryRegionOps applesmc_cmd_io_ops = {
 static const MemoryRegionOps applesmc_err_io_ops = {
     .write = applesmc_io_err_write,
     .read = applesmc_io_err_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
diff --git a/hw/misc/arm11scu.c b/hw/misc/arm11scu.c
index 3023284d6f..dd690dc985 100644
--- a/hw/misc/arm11scu.c
+++ b/hw/misc/arm11scu.c
@@ -58,7 +58,7 @@ static void mpcore_scu_write(void *opaque, hwaddr offset,
 static const MemoryRegionOps mpcore_scu_ops = {
     .read = mpcore_scu_read,
     .write = mpcore_scu_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
 };
 
 static void arm11_scu_realize(DeviceState *dev, Error **errp)
diff --git a/hw/misc/arm_l2x0.c b/hw/misc/arm_l2x0.c
index af2c7af4a0..cd1747b7a1 100644
--- a/hw/misc/arm_l2x0.c
+++ b/hw/misc/arm_l2x0.c
@@ -159,7 +159,7 @@ static void l2x0_priv_reset(DeviceState *dev)
 static const MemoryRegionOps l2x0_mem_ops = {
     .read = l2x0_priv_read,
     .write = l2x0_priv_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
  };
 
 static void l2x0_priv_init(Object *obj)
diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c
index c213500d9c..b04950ecb9 100644
--- a/hw/misc/puv3_pm.c
+++ b/hw/misc/puv3_pm.c
@@ -117,7 +117,7 @@ static const MemoryRegionOps puv3_pm_ops = {
         .min_access_size = 4,
         .max_access_size = 4,
     },
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
 };
 
 static void puv3_pm_realize(DeviceState *dev, Error **errp)
-- 
2.23.0



  parent reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23 18:56 [Qemu-devel] [RFC PATCH 00/17] " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 01/17] hw/audio: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 02/17] hw/block: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 03/17] hw/char: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 04/17] hw/display: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 05/17] hw/dma: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 06/17] hw/gpio: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 07/17] hw/i2c: " Tony Nguyen
2019-08-24  9:27   ` David Gibson
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 08/17] hw/input: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 09/17] hw/intc: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 10/17] hw/isa: " Tony Nguyen
2019-08-23 18:56 ` Tony Nguyen [this message]
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 12/17] hw/net: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 13/17] hw/pci-host: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 14/17] hw/sd: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 15/17] hw/ssi: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 16/17] hw/timer: " Tony Nguyen
2019-08-23 18:56 ` [Qemu-devel] [RFC PATCH 17/17] build: Correct non-common common-obj-* to obj-* Tony Nguyen
2019-08-23 20:05   ` Paolo Bonzini
2019-08-23 19:42 ` [Qemu-devel] [RFC PATCH 00/17] Declare device little or big endian no-reply

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=094d765fcaa42b40328186129628b188b2b93477.1566467963.git.tony.nguyen@bt.com \
    --to=tony.nguyen@bt.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git