From: Johannes Berg <johannes@sipsolutions.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC v2 1/2] docs: vhost-user: add in-band kick/call messages
Date: Tue, 17 Sep 2019 14:01:38 +0200 [thread overview]
Message-ID: <0978f7296c9cb2da303ccae38941eb6fc9c4dbe1.camel@sipsolutions.net> (raw)
In-Reply-To: <20190916112430-mutt-send-email-mst@kernel.org>
On Mon, 2019-09-16 at 11:30 -0400, Michael S. Tsirkin wrote:
>
> So first we really need to fix up Starting and stopping section,
> explaining that if the FD is invalid, this means ring
> is immediately started, right?
It actually does say that, and ... I even changed it already to say the
ring is also started when receiving the new VHOST_USER_VRING_KICK
message:
Client must start ring upon receiving a kick (that is, detecting that
file descriptor is readable) on the descriptor specified by
``VHOST_USER_SET_VRING_KICK`` (or receiving the in-band message
``VHOST_USER_VRING_KICK`` if negotiated) and stop ring upon receiving
``VHOST_USER_GET_VRING_BASE``.
> If we want to keep it simple, my proposal is this, if
> VHOST_USER_PROTOCOL_F_IN_BAND_NOTIFICATIONS is set then
> VHOST_USER_SET_VRING_CALL and VHOST_USER_SET_VRING_KICK are not valid.
> Starting/stopping ring needs to be updated, teaching it
> that ring is started after it gets a kick.
Makes sense, mostly I just need to actually *implement* that.
johannes
next prev parent reply other threads:[~2019-09-17 12:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 13:45 [Qemu-devel] [RFC v2 0/2] vhost-user: in-band notifications Johannes Berg
2019-09-11 13:45 ` [Qemu-devel] [RFC v2 1/2] docs: vhost-user: add in-band kick/call messages Johannes Berg
2019-09-11 14:07 ` Michael S. Tsirkin
2019-09-11 15:09 ` Johannes Berg
2019-09-16 11:40 ` Johannes Berg
2019-09-16 15:30 ` Michael S. Tsirkin
2019-09-17 12:01 ` Johannes Berg [this message]
2019-09-11 19:15 ` Dr. David Alan Gilbert
2019-09-11 19:18 ` Johannes Berg
2019-09-12 8:09 ` Dr. David Alan Gilbert
2019-09-12 8:13 ` Johannes Berg
2019-09-11 13:45 ` [Qemu-devel] [RFC v2 2/2] libvhost-user: implement in-band notifications Johannes Berg
2019-09-11 15:01 ` [Qemu-devel] [RFC v2 0/2] vhost-user: " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0978f7296c9cb2da303ccae38941eb6fc9c4dbe1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).