From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Eric Auger" <eric.auger@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 0/4] vl: Prioritize device realizations
Date: Thu, 21 Oct 2021 18:54:59 +0200 [thread overview]
Message-ID: <0a475bcd-b501-e7c4-b2ff-11fae7f6b208@redhat.com> (raw)
In-Reply-To: <YXEeEFuovkNqRRMu@xz-m1.local>
On 21.10.21 10:00, Peter Xu wrote:
> On Thu, Oct 21, 2021 at 09:17:57AM +0200, David Hildenbrand wrote:
>> I know, whenever someone proposes a way to tackle part of a challenging
>> problem, everybody discovers their hopes and dreams and suddenly you
>> have to go all the way to solve the complete problem. The end result is
>> that there is no improvement at all instead of incremental improvement.
>
> Yeah, there's the trade-off; we either not moving forward or otherwise we could
> potentially bring (more) chaos so the code is less maintainable. Before I'm
> sure I won't do the latter and convince the others, I need to hold off a bit. :-)
Sure :)
>> I'm not planning on letting the user set the actual number of memslots
>> to use, only an upper limit. But to me, it's fundamentally the same: the
>> user has to enable this behavior explicitly.
>
> I'm not familiar enough on virtio-mem's side, it's just that it will stop
> working when the ideal value (even in a very corner case) is less than the
> maximum specified, then that trick stops people from specifying the ideal. But
> if it's bigger the better then indeed I don't see much to worry.
Usually it's "the bigger the better", but there are a lot of exceptions,
and error handling on weird user input is a little hairy ... but I'm
playing with it right now, essentially having
"memslots=0" -> auto detect as good as possible
"memslots=1" -> default
"memslits>1" -> use user input, bail out if some conditions aren't met.
Especially, fail plugging if there are not sufficient free memslots around.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-10-21 17:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 19:42 [PATCH 0/4] vl: Prioritize device realizations Peter Xu
2021-08-18 19:42 ` [PATCH 1/4] qdev-monitor: Trace qdev creation Peter Xu
2021-08-18 19:43 ` [PATCH 2/4] qemu-config: Allow in-place sorting of QemuOptsList Peter Xu
2021-08-18 19:43 ` [PATCH 3/4] qdev: Export qdev_get_device_class() Peter Xu
2021-08-18 19:43 ` [PATCH 4/4] vl: Prioritize realizations of devices Peter Xu
2021-08-23 18:49 ` Eduardo Habkost
2021-08-23 19:18 ` Peter Xu
2021-08-23 21:07 ` Eduardo Habkost
2021-08-23 21:31 ` Peter Xu
2021-08-23 21:54 ` Michael S. Tsirkin
2021-08-23 22:51 ` Peter Xu
2021-08-23 21:56 ` Eduardo Habkost
2021-08-23 23:05 ` Peter Xu
2021-08-25 9:39 ` Markus Armbruster
2021-08-25 12:28 ` Markus Armbruster
2021-08-25 21:50 ` Peter Xu
2021-08-26 3:50 ` Peter Xu
2021-08-26 8:01 ` Markus Armbruster
2021-08-26 11:36 ` Igor Mammedov
2021-08-26 13:43 ` Peter Xu
2021-08-30 19:02 ` Peter Xu
2021-08-31 11:35 ` Markus Armbruster
2021-09-02 8:26 ` Igor Mammedov
2021-09-02 13:45 ` Peter Xu
2021-09-02 13:53 ` Daniel P. Berrangé
2021-09-02 14:21 ` Peter Xu
2021-09-02 14:57 ` Markus Armbruster
2021-09-03 15:48 ` Peter Xu
2021-09-02 15:06 ` Daniel P. Berrangé
2021-09-02 15:26 ` Markus Armbruster
2021-09-03 13:00 ` Igor Mammedov
2021-09-03 16:03 ` Peter Xu
2021-09-06 8:49 ` Igor Mammedov
2021-09-02 7:46 ` Igor Mammedov
2021-08-26 4:57 ` Markus Armbruster
2021-08-23 22:05 ` Michael S. Tsirkin
2021-08-23 22:36 ` Peter Xu
2021-08-24 2:52 ` Jason Wang
2021-08-24 15:50 ` Peter Xu
2021-08-25 4:23 ` Jason Wang
2021-09-06 9:22 ` Eric Auger
2021-08-24 16:24 ` David Hildenbrand
2021-08-24 19:52 ` Peter Xu
2021-08-25 8:08 ` David Hildenbrand
2021-08-24 2:51 ` Jason Wang
2021-10-20 13:44 ` [PATCH 0/4] vl: Prioritize device realizations David Hildenbrand
2021-10-20 13:48 ` Daniel P. Berrangé
2021-10-20 13:58 ` David Hildenbrand
2021-10-21 4:20 ` Peter Xu
2021-10-21 7:17 ` David Hildenbrand
2021-10-21 8:00 ` Peter Xu
2021-10-21 16:54 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a475bcd-b501-e7c4-b2ff-11fae7f6b208@redhat.com \
--to=david@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).