From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Denis Lunev <den@virtuozzo.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes
Date: Sun, 25 Aug 2019 10:30:05 +0000 [thread overview]
Message-ID: <0b3f1002-d3c5-a45d-3a91-fbe2acb59db0@virtuozzo.com> (raw)
In-Reply-To: <20190816200527.GA20950@localhost.localdomain>
On 16/08/2019 23:05, Cleber Rosa wrote:
> On Fri, Jul 19, 2019 at 07:30:10PM +0300, Andrey Shinkevich wrote:
>> In the current implementation of the QEMU bash iotests, only qemu-io
>> processes may be run under the Valgrind, which is a useful tool for
>> finding memory usage issues. Let's allow the common.rc bash script
>> runing all the QEMU processes, such as qemu-kvm, qemu-img, qemu-ndb
>> and qemu-vxhs, under the Valgrind tool.
>>
>
> FIY, this looks very similar (in purpose) to:
>
> https://avocado-framework.readthedocs.io/en/71.0/WrapProcess.html
>
> And in fact Valgrind was one of the original motivations:
>
> https://github.com/avocado-framework/avocado/blob/master/examples/wrappers/valgrind.sh
>
> Maybe this can be helpful for the Python based iotests.
>
> - Cleber.
>
Thank you Cleber for the advice. That is the way I actually ran Python
iotests under Valgrind on my host and discovered some issues with them
already.
Andrey
>> v5:
>> 01: The patch "block/nbd: NBDReply is used being uninitialized" was detached
>> and taken into account in the patch "nbd: Initialize reply on failure"
>> by Eric Blake.
>>
>> v4:
>> 01: The patch "iotests: Set read-zeroes on in null block driver for Valgrind"
>> was extended with new cases and issued as a separate series.
>> 02: The new patch "block/nbd: NBDReply is used being uninitialized" was
>> added to resolve the failure of the iotest 083 run under Valgrind.
>>
>> v3:
>> 01: The new function _casenotrun() was added to the common.rc bash
>> script to notify the user of test cases dropped for some reason.
>> Suggested by Kevin.
>> Particularly, the notification about the nonexistent TMPDIR in
>> the test 051 was added (noticed by Vladimir).
>> 02: The timeout in some test cases was extended for Valgrind because
>> it differs when running on the ramdisk.
>> 03: Due to the common.nbd script has been changed with the commit
>> b28f582c, the patch "iotests: amend QEMU NBD process synchronization"
>> is actual no more. Note that QEMU_NBD is launched in the bash nested
>> shell in the _qemu_nbd_wrapper() as it was before in common.rc.
>> 04: The patch "iotests: new file to suppress Valgrind errors" was dropped
>> due to my superficial understanding of the work of the function
>> blk_pread_unthrottled(). Special thanks to Kevin who shed the light
>> on the null block driver involved. Now, the parameter 'read-zeroes=on'
>> is passed to the null block driver to initialize the buffer in the
>> function guess_disk_lchs() that the Valgrind was complaining to.
>>
>> v2:
>> 01: The patch 2/7 of v1 was merged into the patch 1/7, suggested by Daniel.
>> 02: Another patch 7/7 was added to introduce the Valgrind error suppression
>> file into the QEMU project.
>> Discussed in the email thread with the message ID:
>> <1560276131-683243-1-git-send-email-andrey.shinkevich@virtuozzo.com>
>>
>> Andrey Shinkevich (6):
>> iotests: allow Valgrind checking all QEMU processes
>> iotests: exclude killed processes from running under Valgrind
>> iotests: Add casenotrun report to bash tests
>> iotests: Valgrind fails with nonexistent directory
>> iotests: extended timeout under Valgrind
>> iotests: extend sleeping time under Valgrind
>>
>> tests/qemu-iotests/028 | 6 +++-
>> tests/qemu-iotests/039 | 5 +++
>> tests/qemu-iotests/039.out | 30 +++--------------
>> tests/qemu-iotests/051 | 4 +++
>> tests/qemu-iotests/061 | 2 ++
>> tests/qemu-iotests/061.out | 12 ++-----
>> tests/qemu-iotests/137 | 1 +
>> tests/qemu-iotests/137.out | 6 +---
>> tests/qemu-iotests/183 | 9 +++++-
>> tests/qemu-iotests/192 | 6 +++-
>> tests/qemu-iotests/247 | 6 +++-
>> tests/qemu-iotests/common.rc | 76 +++++++++++++++++++++++++++++++++-----------
>> 12 files changed, 101 insertions(+), 62 deletions(-)
>>
>> --
>> 1.8.3.1
>>
>>
--
With the best regards,
Andrey Shinkevich
prev parent reply other threads:[~2019-08-25 10:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 16:30 [Qemu-devel] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes Andrey Shinkevich
2019-07-19 16:30 ` [Qemu-devel] [PATCH v5 1/6] iotests: allow " Andrey Shinkevich
2019-08-15 22:49 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-25 15:26 ` Andrey Shinkevich
2019-08-27 19:56 ` John Snow
2019-08-28 15:04 ` Andrey Shinkevich
2019-07-19 16:30 ` [Qemu-devel] [PATCH v5 2/6] iotests: exclude killed processes from running under Valgrind Andrey Shinkevich
2019-08-16 0:40 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-19 16:30 ` [Qemu-devel] [PATCH v5 3/6] iotests: Add casenotrun report to bash tests Andrey Shinkevich
2019-08-16 0:44 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-16 20:33 ` Cleber Rosa
2019-08-25 13:03 ` Andrey Shinkevich
2019-07-19 16:30 ` [Qemu-devel] [PATCH v5 4/6] iotests: Valgrind fails with nonexistent directory Andrey Shinkevich
2019-08-16 0:55 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-25 15:24 ` Andrey Shinkevich
2019-08-27 19:45 ` John Snow
2019-08-28 15:12 ` Andrey Shinkevich
2019-07-19 16:30 ` [Qemu-devel] [PATCH v5 5/6] iotests: extended timeout under Valgrind Andrey Shinkevich
2019-08-16 0:58 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-19 16:30 ` [Qemu-devel] [PATCH v5 6/6] iotests: extend sleeping time " Andrey Shinkevich
2019-08-16 1:01 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-23 15:27 ` Vladimir Sementsov-Ogievskiy
2019-08-27 19:42 ` John Snow
2019-08-28 15:24 ` Andrey Shinkevich
2019-08-28 17:27 ` John Snow
2019-08-25 10:13 ` Andrey Shinkevich
2019-08-06 16:24 ` [Qemu-devel] [PATCH v5 0/6] Allow Valgrind checking all QEMU processes Andrey Shinkevich
2019-08-16 20:05 ` Cleber Rosa
2019-08-25 10:30 ` Andrey Shinkevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b3f1002-d3c5-a45d-3a91-fbe2acb59db0@virtuozzo.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=crosa@redhat.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).