Re: [PULL 09/36] ui: do not delay further remote resize

[Richard Henderson <richard.henderson@linaro.org>]

On 12/17/21 6:37 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau<marcandre.lureau@redhat.com>
> 
> A remote client, such as Spice, will already avoid flooding the stream
> by delaying the resize requests.
> 
> Signed-off-by: Marc-André Lureau<marcandre.lureau@redhat.com>
> Acked-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   include/ui/console.h | 2 +-
>   ui/console.c         | 5 +++--
>   ui/gtk.c             | 2 +-
>   ui/sdl2.c            | 2 +-
>   ui/spice-display.c   | 2 +-
>   ui/vnc.c             | 2 +-
>   6 files changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/include/ui/console.h b/include/ui/console.h
> index 6d678924f6fd..65e6bbcab8ae 100644
> --- a/include/ui/console.h
> +++ b/include/ui/console.h
> @@ -292,7 +292,7 @@ void unregister_displaychangelistener(DisplayChangeListener *dcl);
>   
>   bool dpy_ui_info_supported(QemuConsole *con);
>   const QemuUIInfo *dpy_get_ui_info(const QemuConsole *con);
> -int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info);
> +int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info, bool delay);
>   

You have failed to update cocoa.m, so the macos build fails.

../ui/cocoa.m:555:35: error: too few arguments to function call, expected 3, have 2
     dpy_set_ui_info(dcl.con, &info);
     ~~~~~~~~~~~~~~~               ^
/private/var/folders/tn/f_9sf1xx5t14qm_6f83q3b840000gn/T/cirrus-ci-build/include/ui/console.h:333:5: 
note: 'dpy_set_ui_info' declared here
int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info, bool delay);
     ^
../ui/cocoa.m:1836:21: error: no member named 'event' in 'struct QemuClipboardNotify'
     switch (notify->event) {
             ~~~~~~  ^

https://gitlab.com/qemu-project/qemu/-/jobs/1898442461


r~