From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 625DCC433DF for ; Fri, 31 Jul 2020 09:47:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C75320829 for ; Fri, 31 Jul 2020 09:47:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SduCl/CS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C75320829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1RdL-0005yA-DQ for qemu-devel@archiver.kernel.org; Fri, 31 Jul 2020 05:47:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1RSc-0005xi-Tb for qemu-devel@nongnu.org; Fri, 31 Jul 2020 05:36:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:31580 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k1RSb-0004KM-D2 for qemu-devel@nongnu.org; Fri, 31 Jul 2020 05:36:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596188168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tO62oqyYFXAABc1+xlCrGDLE5JMEv4dAt+OxOR6NLeg=; b=SduCl/CS+G+rEmmOUm9U9kEm1Xlgkem0QEhl96tuSXblVQ5D/y5whj8r5xrjwinUHBkcMJ 5ah7X8wTKNKRw00Wz3/wsSixPYLsNHCgPYLvH2QCoHWNSaVX+07CpjdJhf+KI1nj9EnVzy o5JkCo0I6ZsYgCVU00r8lqUw/mbu1Sc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-Zf5DtDjvM369PnfCL-8xSw-1; Fri, 31 Jul 2020 05:36:04 -0400 X-MC-Unique: Zf5DtDjvM369PnfCL-8xSw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E98C2801A03; Fri, 31 Jul 2020 09:36:02 +0000 (UTC) Received: from [10.36.114.127] (ovpn-114-127.ams2.redhat.com [10.36.114.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A702D1C92D; Fri, 31 Jul 2020 09:35:52 +0000 (UTC) Subject: Re: [PATCH for-5.2 v4 05/11] hw/arm/smmu-common: Manage IOTLB block entries To: Peter Maydell References: <20200728150815.11446-1-eric.auger@redhat.com> <20200728150815.11446-6-eric.auger@redhat.com> From: Auger Eric Message-ID: <0bf88eb1-c7d8-f81d-e8ba-7c8493c09070@redhat.com> Date: Fri, 31 Jul 2020 11:35:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=eric.auger@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/31 03:06:50 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , "Michael S. Tsirkin" , Will Deacon , zhangfei.gao@foxmail.com, QEMU Developers , Peter Xu , qemu-arm , Shameerali Kolothum Thodi , Robin Murphy , Rob Herring , Eric Auger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, On 7/30/20 3:38 PM, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 16:09, Eric Auger wrote: >> >> At the moment each entry in the IOTLB corresponds to a page sized >> mapping (4K, 16K or 64K), even if the page belongs to a mapped >> block. In case of block mapping this unefficiently consumes IOTLB >> entries. >> >> Change the value of the entry so that it reflects the actual >> mapping it belongs to (block or page start address and size). >> >> Also the level/tg of the entry is encoded in the key. In subsequent >> patches we will enable range invalidation. This latter is able >> to provide the level/tg of the entry. >> >> Encoding the level/tg directly in the key will allow to invalidate >> using g_hash_table_remove() when num_pages equals to 1. >> >> Signed-off-by: Eric Auger >> >> --- >> v3 -> v4: >> - also use the tg field when computing the hash >> - in the key equal function, compare the fields instead of >> using memcmp() >> - fixed a couple of indents >> - added Peter's R-b > > You say that, but you didn't :-) Please forgive me for the oversight. Thank you for the review. Eric > > Reviewed-by: Peter Maydell > > thanks > -- PMM >