From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9017AC33CB1 for ; Thu, 16 Jan 2020 12:37:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 668D12087E for ; Thu, 16 Jan 2020 12:37:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 668D12087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is4PL-000651-Ar for qemu-devel@archiver.kernel.org; Thu, 16 Jan 2020 07:37:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35389) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is4OE-0004wn-IT for qemu-devel@nongnu.org; Thu, 16 Jan 2020 07:36:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is4OA-0006ui-VK for qemu-devel@nongnu.org; Thu, 16 Jan 2020 07:36:46 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51472 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1is4Ny-0006oL-5j; Thu, 16 Jan 2020 07:36:30 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 72E0A1E0430687E18D8E; Thu, 16 Jan 2020 20:36:24 +0800 (CST) Received: from [127.0.0.1] (10.133.216.73) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 16 Jan 2020 20:36:17 +0800 Subject: Re: [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0 To: Igor Mammedov References: <20191219064759.35053-1-guoheyi@huawei.com> <20191219064759.35053-2-guoheyi@huawei.com> <20200113133702.1dea867b@redhat.com> From: Guoheyi Message-ID: <1089b0d5-548e-da54-b59d-484517843411@huawei.com> Date: Thu, 16 Jan 2020 20:36:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200113133702.1dea867b@redhat.com> Content-Type: text/plain; charset="gbk"; format=flowed X-Originating-IP: [10.133.216.73] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Julia Suvorova , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, wanghaibin.wang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" =D4=DA 2020/1/13 20:37, Igor Mammedov =D0=B4=B5=C0: > On Thu, 19 Dec 2019 14:47:58 +0800 > Heyi Guo wrote: > >> The sub device "PR0" under PCI0 in ACPI/DSDT does not make any sense, >> so simply remote it. > Could you make commit message more concrete so it would say > why it doesn't make any sense. The reason I'd like to remove it is that I never see a reason that it=20 should be there :) 1. I searched through ACPI spec and PCI firmware spec, but didn't find=20 any reason for its existance (might miss something). 2. We don't have such "PR0" device on PCI host bridge object on physical=20 arm64 machines and these platforms work well. 3. The VM also works well after removing this device. 4. This device looks strange to only have an identity (_ADR) but not any=20 other attribute; also this device was introduced in the initial commit=20 without any special comment. Thanks, Heyi > > It seems to be there to describe root port, > I'd rather have PCI folk ack if it's ok to remove it. > >> Signed-off-by: Heyi Guo >> >> --- >> Cc: Peter Maydell >> Cc: "Michael S. Tsirkin" >> Cc: Igor Mammedov >> Cc: Shannon Zhao >> Cc: qemu-arm@nongnu.org >> Cc: qemu-devel@nongnu.org >> --- >> hw/arm/virt-acpi-build.c | 4 ---- >> tests/data/acpi/virt/DSDT | Bin 18462 -> 18449 bytes >> tests/data/acpi/virt/DSDT.memhp | Bin 19799 -> 19786 bytes >> tests/data/acpi/virt/DSDT.numamem | Bin 18462 -> 18449 bytes >> 4 files changed, 4 deletions(-) >> >> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >> index bd5f771e9b..9f4c7d1889 100644 >> --- a/hw/arm/virt-acpi-build.c >> +++ b/hw/arm/virt-acpi-build.c >> @@ -317,10 +317,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const M= emMapEntry *memmap, >> aml_append(method, aml_return(buf)); >> aml_append(dev, method); >> =20 >> - Aml *dev_rp0 =3D aml_device("%s", "RP0"); >> - aml_append(dev_rp0, aml_name_decl("_ADR", aml_int(0))); >> - aml_append(dev, dev_rp0); >> - >> Aml *dev_res0 =3D aml_device("%s", "RES0"); >> aml_append(dev_res0, aml_name_decl("_HID", aml_string("PNP0C02")= )); >> crs =3D aml_resource_template(); >> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT >> index d0f3afeb134fdf1c11f64cd06dbcdd30be603b80..b5895cb22446860a0b9be3= d32ec856feb388be4c 100644 >> GIT binary patch >> delta 39 >> vcmbO?fpOvlMlP3Nmk>b@1_q`B6S<_Bdg?Z+cXBfI+}XT|v(|R9jr$`2@RSW) >> >> delta 50 >> zcmbO@fpOjhMlP3Nmk>D*1_q{tiCof5o%I{lJ2{y;?{412S!>J19TZ>?&k^tF5;R%I >> G{V4!>hYx%J >> >> diff --git a/tests/data/acpi/virt/DSDT.memhp b/tests/data/acpi/virt/DS= DT.memhp >> index 41ccc6431b917252bcbaac86c33b340c796be5ce..69ad844f65d047973a3e55= 198beecd45a35b8fce 100644 >> GIT binary patch >> delta 40 >> wcmcaUi}BPfMlP3Nmk=3D*s1_q}3iCof5t(P{ccXBfI+}XT|v(|RAjk`1(02g)*ivR!s >> >> delta 51 >> zcmX>#i}Cs_MlP3NmymE@1_mbiiCof5O_w*ScXBdy-rc;3v(}c2J1D>)o+IATC1|sb >> HyBr$;t7;Fc >> >> diff --git a/tests/data/acpi/virt/DSDT.numamem b/tests/data/acpi/virt/= DSDT.numamem >> index d0f3afeb134fdf1c11f64cd06dbcdd30be603b80..b5895cb22446860a0b9be3= d32ec856feb388be4c 100644 >> GIT binary patch >> delta 39 >> vcmbO?fpOvlMlP3Nmk>b@1_q`B6S<_Bdg?Z+cXBfI+}XT|v(|R9jr$`2@RSW) >> >> delta 50 >> zcmbO@fpOjhMlP3Nmk>D*1_q{tiCof5o%I{lJ2{y;?{412S!>J19TZ>?&k^tF5;R%I >> G{V4!>hYx%J >> > > .