From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, thuth@redhat.com, berrange@redhat.com,
ehabkost@redhat.com, pbonzini@redhat.com, alex.bennee@linaro.org
Subject: Re: [PATCH for-5.1 3/5] qom: Change object_get_canonical_path_component() not to malloc
Date: Tue, 14 Jul 2020 18:21:04 +0200 [thread overview]
Message-ID: <10950d76-a58a-0e5f-ba79-71159c9ad4a3@redhat.com> (raw)
In-Reply-To: <20200714160202.3121879-4-armbru@redhat.com>
On 7/14/20 6:02 PM, Markus Armbruster wrote:
> object_get_canonical_path_component() returns a malloced copy of a
> property name on success, null on failure.
>
> 19 of its 25 callers immediately free the returned copy.
>
> Change object_get_canonical_path_component() to return the property
> name directly. Since modifying the name would be wrong, adjust the
> return type to const char *.
Yeah!
>
> Drop the free from the 19 callers become simpler, add the g_strdup()
> to the other six.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qom/object.h | 2 +-
> backends/hostmem.c | 2 +-
> block/throttle-groups.c | 2 +-
> gdbstub.c | 2 +-
> hw/arm/xlnx-zynqmp.c | 6 ++----
> hw/block/nvme.c | 5 ++---
> hw/core/machine-qmp-cmds.c | 2 +-
> hw/core/machine.c | 5 ++---
> hw/mem/nvdimm.c | 5 ++---
> hw/mem/pc-dimm.c | 5 ++---
> hw/misc/ivshmem.c | 5 ++---
> hw/ppc/spapr_drc.c | 3 +--
> hw/virtio/virtio-crypto.c | 5 ++---
> hw/virtio/virtio-mem.c | 6 ++----
> hw/virtio/virtio-pmem.c | 5 ++---
> iothread.c | 9 ++++-----
> net/net.c | 6 ++----
> qom/object.c | 7 +++----
> qom/qom-hmp-cmds.c | 11 ++++-------
> scsi/pr-manager-helper.c | 3 +--
> scsi/pr-manager.c | 2 +-
> softmmu/memory.c | 2 +-
> hw/ppc/trace-events | 2 +-
> 23 files changed, 41 insertions(+), 61 deletions(-)
...
> @@ -303,7 +302,7 @@ type_init(iothread_register_types)
>
> char *iothread_get_id(IOThread *iothread)
> {
> - return object_get_canonical_path_component(OBJECT(iothread));
> + return g_strdup(object_get_canonical_path_component(OBJECT(iothread)));
> }
(Note for later, this one can return const).
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-07-14 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 16:01 [PATCH for-5.1 0/5] qom: HMP command fixes Markus Armbruster
2020-07-14 16:01 ` [PATCH for-5.1 1/5] qdev: Fix device_add DRIVER, help to print to monitor Markus Armbruster
2020-07-14 16:22 ` Philippe Mathieu-Daudé
2020-07-15 15:18 ` Li Qiang
2020-07-21 15:17 ` Dr. David Alan Gilbert
2020-07-14 16:01 ` [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree" Markus Armbruster
2020-07-14 16:16 ` Philippe Mathieu-Daudé
2020-07-14 16:46 ` Philippe Mathieu-Daudé
2020-07-15 15:19 ` Li Qiang
2020-07-16 9:05 ` Thomas Huth
2020-07-14 16:02 ` [PATCH for-5.1 3/5] qom: Change object_get_canonical_path_component() not to malloc Markus Armbruster
2020-07-14 16:21 ` Philippe Mathieu-Daudé [this message]
2020-07-15 15:26 ` Li Qiang
2020-07-14 16:02 ` [PATCH for-5.1 4/5] qom: Document object_get_canonical_path() returns malloced string Markus Armbruster
2020-07-14 16:23 ` Philippe Mathieu-Daudé
2020-07-14 16:02 ` [PATCH for-5.1 5/5] qom: Make info qom-tree sort children more efficiently Markus Armbruster
2020-07-21 15:32 ` Dr. David Alan Gilbert
2020-07-21 15:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10950d76-a58a-0e5f-ba79-71159c9ad4a3@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).