From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D3DC4338F for ; Sun, 15 Aug 2021 20:03:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BFF861354 for ; Sun, 15 Aug 2021 20:03:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BFF861354 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFMMG-0003gm-CH for qemu-devel@archiver.kernel.org; Sun, 15 Aug 2021 16:03:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFMJB-0000e6-Ae for qemu-devel@nongnu.org; Sun, 15 Aug 2021 16:00:37 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:35692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFMJ9-0002Tq-2l for qemu-devel@nongnu.org; Sun, 15 Aug 2021 16:00:37 -0400 Received: by mail-pl1-x62c.google.com with SMTP id c17so13185445plz.2 for ; Sun, 15 Aug 2021 13:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/4toCiHyuNDrC5O23EgC39m8GgNwq82B/0Or2hqVnEo=; b=h40VAY/fSUcEbqt98Wtf537XEmOgAEtvbfzQz+Ldq7xMo38hNAS18aJZIV9bt+g0HH itC2BqgIZPA4wWYsgNZG6rE31EcrdIL+OwBVnockgjlYRkzM28IXH9Bxa9Zy49Em74Dj ryFXkcFIbZLq/qMBLpAzgrceqQqUx126DILUeYAlPHEWRPVaVm7VabTGRjstrtZ5zZkX dDWU15efpxvQomufRYPRwvWCUYzslwcVLe/xQpDAj1YxW3yFv+yW52XnM5xyQjn7h60+ lucN4FmMQE8xS4E/oCga4AEJQfPcNx3t3gANlbtMTfDuxDD1IfbWz8zVPjajDBrRIJuL DYpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/4toCiHyuNDrC5O23EgC39m8GgNwq82B/0Or2hqVnEo=; b=BpVm7E8NP5hN2MPMGl8DMP3Qto3eHqCGLxy00nF2sPwWdeUBz3MoV5XStNZeDbuLxQ rYTVlHbKKcogZdtbFhfNmvMOYXMgf3eAEXdksFSMIE2QPpRgtYh3O74cztY37CsP8eur ZwI1g2jH2AvC766+G+XiiKVC59D6uVpSv+rFcSuh+DxDXLsO5Nmk+6ZQ05xPP6w7/4Zv e1jkyS3scbYKyN1P9oDsI83faYwouA7DXXBDUDAJlRZpPLob7XrS+0g9ran3taKhk5R9 L7UZfp6sOT/whBMHdA2o6Y4vRiVpBR04Ps3Sw+p1q8jZ933yD0doxtD/ntPrv0wgAw57 xAow== X-Gm-Message-State: AOAM532HCVGxMrSfy+Nk9nMJ6gP02Sd5ahqlnCqMQgqgs64aYfeBUMef EbjOEf/oFV75Io3C/wwWcgiT3w== X-Google-Smtp-Source: ABdhPJzgaXlqSb+TUgzxtd5A2oQ6q/jkNx5y3/yBDTGVbbEyBvFsqS7yolyZ6p4S7Jrp6jZUYNaUCQ== X-Received: by 2002:aa7:9dce:0:b0:3e1:3c5d:640d with SMTP id g14-20020aa79dce000000b003e13c5d640dmr8332921pfq.25.1629057633423; Sun, 15 Aug 2021 13:00:33 -0700 (PDT) Received: from [192.168.3.43] ([173.197.107.15]) by smtp.gmail.com with ESMTPSA id p190sm9175945pfb.4.2021.08.15.13.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Aug 2021 13:00:33 -0700 (PDT) Subject: Re: [PATCH for-6.2 4/7] linux-user: Zero out target_siginfo_t in force_sig() To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210813131809.28655-1-peter.maydell@linaro.org> <20210813131809.28655-5-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <115c040b-8357-02bf-1483-3b3f5e56d20c@linaro.org> Date: Sun, 15 Aug 2021 10:00:29 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210813131809.28655-5-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.147, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/13/21 3:18 AM, Peter Maydell wrote: > The target_siginfo_t we populate in force_sig() will eventually > get copied onto the target's stack. Zero it out so that any extra > padding in the sifields union is consistently zero when the guest > sees it. > > Signed-off-by: Peter Maydell > --- > linux-user/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~