From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pagupta@redhat.com>) id 1aVJK0-0001Ij-1g
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:36:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pagupta@redhat.com>) id 1aVJJw-0000VC-SW
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:36:11 -0500
Received: from mx6-phx2.redhat.com ([209.132.183.39]:43369)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pagupta@redhat.com>) id 1aVJJw-0000Tg-Kf
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:36:08 -0500
Date: Mon, 15 Feb 2016 08:36:06 -0500 (EST)
From: Pankaj Gupta <pagupta@redhat.com>
Message-ID: <1180669889.18225375.1455543366891.JavaMail.zimbra@redhat.com>
In-Reply-To: <1455119605-31261-1-git-send-email-lprosek@redhat.com>
References: <1455119605-31261-1-git-send-email-lprosek@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/4] rng-random: implement request queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ladi Prosek <lprosek@redhat.com>
Cc: amit shah <amit.shah@redhat.com>, pbonzini@redhat.com, qemu-devel@nongnu.org


> 
> As suggested by Paolo, I have moved the RngRequest implementation
> up to the RngBackend parent class and made both child classes use
> it. Apart from the refactoring, the only functional change
> compared to v1 is the use of heap instead of stack allocation for
> the read buffer in rng-random.
> 
> The parent class takes care of creating new requests and adding
> them to the queue, as well as removing them from the queue and
> deleting them. Child classes have access to the raw GSList * to
> do whatever else they need to do (walk the queue, peek the head
> of the queue, ..)

Hi Ladi,

Overall code changes looks good to me.
 
> 
> [PATCH v2 1/4] rng: remove the unused request cancellation code
> [PATCH v2 2/4] rng: move request queue from RngEgd to RngBackend
> [PATCH v2 3/4] rng: move request queue cleanup from RngEgd to
> [PATCH v2 4/4] rng: add request queue support to rng-random
> 
>