From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v2 0/2] Rework iotests finding
Date: Wed, 25 Mar 2020 08:08:51 -0500 [thread overview]
Message-ID: <11877a2e-2815-19d9-603f-b7ea52cc3d6f@redhat.com> (raw)
In-Reply-To: <20200325102131.23270-1-vsementsov@virtuozzo.com>
On 3/25/20 5:21 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> When sending iotests to upstream or do patch porting from one branch
> to another we very often have to resolve conflicts in group file, as
> many absolutely independent features are intersecting by this file.
> These conflicts are simple, but imagine how much time we all have
> already spent on resolving them? Let's finally get rid of group file.
>
> Next, another thing I don't like about iotests is race for test number
> chosing: you should search through mail box, before chosing test number
> for new test.
>
> So, I propose to get rid of group file and search for tests another way
> [look at patch 02]. Additionally I propose to move to human-readable
> names for test files, with notation test-* .
I suggest swapping the name: It's easier to write a glob for *-test vs.
*-test.out than it is to write for test-* but not test-*.out. (You
don't want to execute the output files as a test). That is, I suggest
that ./check consider all 3-digit files and all files ending in -test as
tests.
>
> v1 was one patch "[PATCH] iotests: drop group file"
>
> Vladimir Sementsov-Ogievskiy (2):
> iotests: define group in each iotests
> iotests: rework test finding
Do you plan on an additional patch (or set of patches) to rename some or
all of the existing 3-digit tests?
Overall, having sensibly named tests makes sense to me.
If we are going to rename files, I'd also suggest that we rename the
directory: tests/qemu-iotests/ feels redundant, compared to tests/iotests.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-25 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 10:21 [PATCH v2 0/2] Rework iotests finding Vladimir Sementsov-Ogievskiy
2020-03-25 10:21 ` [PATCH v2 1/2] iotests: define group in each iotests Vladimir Sementsov-Ogievskiy
2020-03-25 10:21 ` [PATCH v2 2/2] iotests: rework test finding Vladimir Sementsov-Ogievskiy
2020-04-06 13:02 ` Max Reitz
2020-04-07 7:37 ` Vladimir Sementsov-Ogievskiy
2020-03-25 11:56 ` [PATCH v2 0/2] Rework iotests finding no-reply
2020-03-25 12:35 ` Vladimir Sementsov-Ogievskiy
2020-03-25 13:08 ` Eric Blake [this message]
2020-03-25 13:26 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11877a2e-2815-19d9-603f-b7ea52cc3d6f@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).