From: Max Reitz <mreitz@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH v3 0/6] Enable more iotests during "make check-block"
Date: Tue, 22 Oct 2019 15:39:39 +0200 [thread overview]
Message-ID: <123b2e94-3f43-1a8e-2420-12ae09483e2f@redhat.com> (raw)
In-Reply-To: <87a79sx6uc.fsf@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 2568 bytes --]
On 22.10.19 15:11, Alex Bennée wrote:
>
> Thomas Huth <thuth@redhat.com> writes:
>
>> As discussed here:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg00697.html
>>
>> and here:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01388.html
>
> Queued to testing/next, thanks.
It should be noted that this series depends on my SOCK_DIR series (which
I have in my block branch), or the newly added tests are likely to fail
in the CI environment.
Max
>>
>> it would be good to have some more valuable iotests enabled in the
>> "auto" group to get better iotest coverage during "make check".
>>
>> And once Max' "iotests: Add and use $SOCK_DIR" patch series has been
>> merged, we can indeed enable these Python-based tests, too.
>>
>> There is just one small downside: Since these tests require a QEMU
>> that features a 'virtio-blk' device, we cannot run the iotests
>> with binaries like qemu-system-tricore anymore. But since the iotests
>> were not very useful with such binaries anyway, I think it's ok now
>> if we skip them there.
>>
>> I've also added a patch that removes test 130 from the "auto" group
>> instead. Test 130 has been reported to fail intermittently, so we
>> should not use it in "make check" block until it is fixed.
>>
>> Based-on: 20191010152457.17713-1-mreitz@redhat.com
>>
>> v3:
>> - Test 183 fails on Patchew, so I removed it from the "auto" group
>> again
>>
>> v2:
>> - Checked the iotests with NetBSD, too (now that Eduardo has
>> re-activated Gerd's patches for creating NetBSD VM images)
>> - Use 'openbsd' instead of 'openbsd6'
>> - Use 'grep -q' instead of 'grep' for grep'ing silently
>> - Added the patch to disable 130 from the "auto" group
>>
>> John Snow (1):
>> iotests: remove 'linux' from default supported platforms
>>
>> Thomas Huth (5):
>> iotests: Test 041 only works on certain systems
>> iotests: Test 183 does not work on macOS and OpenBSD
>> iotests: Skip "make check-block" if QEMU does not support virtio-blk
>> iotests: Enable more tests in the 'auto' group to improve test
>> coverage
>> iotests: Remove 130 from the "auto" group
>>
>> tests/check-block.sh | 16 +++++++++++++++-
>> tests/qemu-iotests/041 | 3 ++-
>> tests/qemu-iotests/183 | 1 +
>> tests/qemu-iotests/group | 18 +++++++++---------
>> tests/qemu-iotests/iotests.py | 16 +++++++++++-----
>> 5 files changed, 38 insertions(+), 16 deletions(-)
>
>
> --
> Alex Bennée
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-22 14:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 7:21 [PATCH v3 0/6] Enable more iotests during "make check-block" Thomas Huth
2019-10-22 7:21 ` [PATCH v3 1/6] iotests: remove 'linux' from default supported platforms Thomas Huth
2019-10-22 7:21 ` [PATCH v3 2/6] iotests: Test 041 only works on certain systems Thomas Huth
2019-10-22 7:21 ` [PATCH v3 3/6] iotests: Test 183 does not work on macOS and OpenBSD Thomas Huth
2019-10-22 7:21 ` [PATCH v3 4/6] iotests: Skip "make check-block" if QEMU does not support virtio-blk Thomas Huth
2019-10-30 11:21 ` Max Reitz
2019-11-11 14:02 ` Thomas Huth
2019-11-11 16:10 ` Max Reitz
2019-10-22 7:21 ` [PATCH v3 5/6] iotests: Enable more tests in the 'auto' group to improve test coverage Thomas Huth
2019-10-24 11:14 ` Alex Bennée
2019-11-27 14:11 ` Thomas Huth
2019-10-22 7:21 ` [PATCH v3 6/6] iotests: Remove 130 from the "auto" group Thomas Huth
2019-10-22 7:58 ` [PATCH v3 0/6] Enable more iotests during "make check-block" Thomas Huth
2019-10-22 11:39 ` Alex Bennée
2019-10-22 11:46 ` Thomas Huth
2019-10-22 13:09 ` Alex Bennée
2019-10-22 13:11 ` Alex Bennée
2019-10-22 13:39 ` Max Reitz [this message]
2019-10-22 13:48 ` Alex Bennée
2019-10-22 18:54 ` Thomas Huth
2019-10-22 21:16 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=123b2e94-3f43-1a8e-2420-12ae09483e2f@redhat.com \
--to=mreitz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).