qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Greg Kurz <groug@kaod.org>
Cc: qemu-ppc@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
	qemu-devel@nongnu.org
Subject: [PATCH v1 6/9] hw/mos6522: Call mos6522_update_irq() when appropriate
Date: Fri, 24 Sep 2021 08:49:56 +1000	[thread overview]
Message-ID: <1257e8f12a02c8794e0a8682ef860b569f1d9ce1.1632437396.git.fthain@linux-m68k.org> (raw)
In-Reply-To: <cover.1632437396.git.fthain@linux-m68k.org>

It necessary to call mos6522_update_irq() when the interrupt flags
change and unnecessary when they haven't.

Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/mos6522.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c
index 6bd60f2118..bfe1719b18 100644
--- a/hw/misc/mos6522.c
+++ b/hw/misc/mos6522.c
@@ -203,10 +203,12 @@ uint64_t mos6522_read(void *opaque, hwaddr addr, unsigned size)
     if (now >= s->timers[0].next_irq_time) {
         mos6522_timer1_update(s, &s->timers[0], now);
         s->ifr |= T1_INT;
+        mos6522_update_irq(s);
     }
     if (now >= s->timers[1].next_irq_time) {
         mos6522_timer2_update(s, &s->timers[1], now);
         s->ifr |= T2_INT;
+        mos6522_update_irq(s);
     }
     switch (addr) {
     case VIA_REG_B:
@@ -231,7 +233,6 @@ uint64_t mos6522_read(void *opaque, hwaddr addr, unsigned size)
         break;
     case VIA_REG_T1CH:
         val = get_counter(s, &s->timers[0]) >> 8;
-        mos6522_update_irq(s);
         break;
     case VIA_REG_T1LL:
         val = s->timers[0].latch & 0xff;
-- 
2.26.3



  parent reply	other threads:[~2021-09-24  0:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 22:49 [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements Finn Thain
2021-09-23 22:49 ` [PATCH v1 9/9] hw/mos6522: Implement oneshot mode Finn Thain
2021-09-23 22:49 ` [PATCH v1 1/9] hw/mos6522: Remove get_load_time() methods and functions Finn Thain
2021-09-23 22:49 ` [PATCH v1 8/9] hw/mos6522: Synchronize timer interrupt and timer counter Finn Thain
2021-09-23 22:49 ` [PATCH v1 7/9] hw/mos6522: Avoid using discrepant QEMU clock values Finn Thain
2021-09-23 22:49 ` [PATCH v1 4/9] hw/mos6522: Rename timer callback functions Finn Thain
2021-09-23 22:49 ` [PATCH v1 3/9] hw/mos6522: Remove redundant mos6522_timer1_update() calls Finn Thain
2021-09-23 22:49 ` Finn Thain [this message]
2021-09-23 22:49 ` [PATCH v1 5/9] hw/mos6522: Fix initial timer counter reload Finn Thain
2021-09-23 22:49 ` [PATCH v1 2/9] hw/mos6522: Remove get_counter_value() methods and functions Finn Thain
2021-11-17  3:03 ` [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements Finn Thain
2021-11-18 11:13   ` Mark Cave-Ayland
2021-11-19  8:39     ` Finn Thain
2021-11-20 21:53       ` Mark Cave-Ayland
2021-11-20 23:38         ` Finn Thain
2021-11-22 17:00           ` Peter Maydell
2021-11-22 22:34             ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257e8f12a02c8794e0a8682ef860b569f1d9ce1.1632437396.git.fthain@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=groug@kaod.org \
    --cc=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).