From: Thomas Huth <thuth@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, lvivier@redhat.com, hare@suse.com,
vsementsov@virtuozzo.com, armbru@redhat.com,
keith.busch@intel.com, kraxel@redhat.com, stefanha@redhat.com,
den@openvz.org, pbonzini@redhat.com, fam@euphon.net
Subject: Re: [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver
Date: Tue, 30 Jul 2019 14:52:23 +0200 [thread overview]
Message-ID: <13985217-0967-e7b6-db62-43c865d49141@redhat.com> (raw)
In-Reply-To: <1564404360-733987-1-git-send-email-andrey.shinkevich@virtuozzo.com>
On 29/07/2019 14.46, Andrey Shinkevich wrote:
> This patch is to reduce the number of Valgrind report messages about
> using uninitialized memory with the null-co driver. It helps to filter
> real memory issues and is the same work done for the iotests with the
> commit ID a6862418fec4072.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
[...]
> diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
> index 86606f9..7da9216 100644
> --- a/tests/test-blockjob-txn.c
> +++ b/tests/test-blockjob-txn.c
> @@ -15,6 +15,7 @@
> #include "qemu/main-loop.h"
> #include "block/blockjob_int.h"
> #include "sysemu/block-backend.h"
> +#include "qapi/qmp/qdict.h"
>
> typedef struct {
> BlockJob common;
> @@ -96,7 +97,9 @@ static BlockJob *test_block_job_start(unsigned int iterations,
>
> data = g_new0(TestBlockJobCBData, 1);
>
> - bs = bdrv_open("null-co://", NULL, NULL, 0, &error_abort);
> + QDict *opt = qdict_new();
> + qdict_put_str(opt, "file.read-zeroes", "on");
> + bs = bdrv_open("null-co://", NULL, opt, 0, &error_abort);
> g_assert_nonnull(bs);
Not sure, but don't you need to also qdict_destroy_obj(opt) at the end
to avoid leaking memory? (Also in the other spots where you use
qdict_new() ...)
Thomas
next prev parent reply other threads:[~2019-07-30 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 12:46 [Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver Andrey Shinkevich
2019-07-30 12:52 ` Thomas Huth [this message]
2019-07-30 12:59 ` Thomas Huth
2019-07-30 13:23 ` Andrey Shinkevich
2019-08-13 8:46 ` Thomas Huth
2019-08-13 10:12 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13985217-0967-e7b6-db62-43c865d49141@redhat.com \
--to=thuth@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=hare@suse.com \
--cc=keith.busch@intel.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).