Re: [PATCH v10 12/12] migration: introduce snapshot-{save,load,delete} QMP commands

[Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>]

02.02.2021 21:14, Eric Blake wrote:
> On 2/2/21 9:41 AM, Daniel P. Berrangé wrote:
>> savevm, loadvm and delvm are some of the few HMP commands that have never
>> been converted to use QMP. The reasons for the lack of conversion are
>> that they blocked execution of the event thread, and the semantics
>> around choice of disks were ill-defined.
>>
> 
>> Note that the existing "query-named-block-nodes" can be used to query
>> what snapshots currently exist for block nodes.
>>
>> Acked-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>   migration/savevm.c                            | 184 +++++++
>>   qapi/job.json                                 |   9 +-
>>   qapi/migration.json                           | 157 ++++++
>>   .../tests/internal-snapshots-qapi             | 386 +++++++++++++
>>   .../tests/internal-snapshots-qapi.out         | 520 ++++++++++++++++++
> 
> Not this patch's fault: I find the name tests/qemu-iotests/tests/name to
> be rather long and a bit repetitive; maybe we want to rename the
> directory structure to something simpler, like:
> 
> tests/iotests/name
> 
> (that is, move the named tests into a sibling directory of
> qemu-iotests/check, rather than a subdirectory).

Still, I think splitting test files from library (check, testenv, common.rc, etc) is a good thing.

I remember someone suggested to rename qemu-iotests to just io..

so we can have tests/io/tests/name

or may be, what about

tests/io/name

and

tests/io/lib/{check,testenv,common.rc,etc}

> And maybe rename
> qemu-iotests/check to something that requires less typing.  Oh, and
> while I'm asking for rainbows and ponies, being able to run check from
> the same directory where I run make, instead of having to change
> directories, would be nice.  But as I said, that's a wish list for a
> separate series.


I run check from any directory with my script:

# cat /work/scripts/check
#!/bin/bash

root=$(git rev-parse --show-toplevel) || exit

dir="$root/build/tests/qemu-iotests"
check="$dir/check"

test -f "$check" || { echo "Can't find '$check'. Is it a Qemu git?"; exit 1; }

cd "$dir"
./check $@


-- 
Best regards,
Vladimir