From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHFof-0005Po-HV for qemu-devel@nongnu.org; Mon, 20 Jul 2015 14:29:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHFod-0003Gv-LV for qemu-devel@nongnu.org; Mon, 20 Jul 2015 14:29:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHFod-0003Gr-GO for qemu-devel@nongnu.org; Mon, 20 Jul 2015 14:29:27 -0400 From: John Snow Date: Mon, 20 Jul 2015 14:29:21 -0400 Message-Id: <1437416961-26348-4-git-send-email-jsnow@redhat.com> In-Reply-To: <1437416961-26348-1-git-send-email-jsnow@redhat.com> References: <1437416961-26348-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PULL 3/3] tests: Fix broken targets check-report-qtest-* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, jsnow@redhat.com, Stefan Weil From: Stefan Weil They need QTEST_QEMU_IMG. Without it, the tests raise an assertion: $ make -C bin check-report-qtest-i386.xml make: Entering directory 'bin' GTESTER check-report-qtest-i386.xml blkdebug: Suspended request 'A' blkdebug: Resuming request 'A' ahci-test: tests/libqos/libqos.c:162: mkimg: Assertion `qemu_img_path' failed. main-loop: WARNING: I/O thread spun for 1000 iterations Signed-off-by: Stefan Weil Reviewed-by: John Snow Message-id: 1437231284-17455-1-git-send-email-sw@weilnetz.de Signed-off-by: John Snow --- tests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile b/tests/Makefile index 2c4b8dc..8d26736 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: % $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ + QTEST_QEMU_IMG=qemu-img$(EXESUF) \ gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@") check-report-unit.xml: $(check-unit-y) -- 2.1.0