From: Janosch Frank <frankja@linux.vnet.ibm.com>
To: pbonzini@redhat.com
Cc: frankja@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 04/34] scripts/kvm/kvm_stat: Removed unneeded PERF constants
Date: Mon, 11 Jan 2016 16:17:34 +0100 [thread overview]
Message-ID: <1452525484-32309-5-git-send-email-frankja@linux.vnet.ibm.com> (raw)
In-Reply-To: <1452525484-32309-1-git-send-email-frankja@linux.vnet.ibm.com>
Only two of the constants are actually needed to set up the events, so
the others were removed. All variables that used them were also removed.
Signed-off-by: Janosch Frank <frankja@linux.vnet.ibm.com>
---
scripts/kvm/kvm_stat | 28 ++--------------------------
1 file changed, 2 insertions(+), 26 deletions(-)
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index c4bf900..7a8617d 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -325,29 +325,8 @@ def _perf_event_open(attr, pid, cpu, group_fd, flags):
ctypes.c_int(cpu), ctypes.c_int(group_fd),
ctypes.c_long(flags))
-PERF_TYPE_HARDWARE = 0
-PERF_TYPE_SOFTWARE = 1
-PERF_TYPE_TRACEPOINT = 2
-PERF_TYPE_HW_CACHE = 3
-PERF_TYPE_RAW = 4
-PERF_TYPE_BREAKPOINT = 5
-
-PERF_SAMPLE_IP = 1 << 0
-PERF_SAMPLE_TID = 1 << 1
-PERF_SAMPLE_TIME = 1 << 2
-PERF_SAMPLE_ADDR = 1 << 3
-PERF_SAMPLE_READ = 1 << 4
-PERF_SAMPLE_CALLCHAIN = 1 << 5
-PERF_SAMPLE_ID = 1 << 6
-PERF_SAMPLE_CPU = 1 << 7
-PERF_SAMPLE_PERIOD = 1 << 8
-PERF_SAMPLE_STREAM_ID = 1 << 9
-PERF_SAMPLE_RAW = 1 << 10
-
-PERF_FORMAT_TOTAL_TIME_ENABLED = 1 << 0
-PERF_FORMAT_TOTAL_TIME_RUNNING = 1 << 1
-PERF_FORMAT_ID = 1 << 2
-PERF_FORMAT_GROUP = 1 << 3
+PERF_TYPE_TRACEPOINT = 2
+PERF_FORMAT_GROUP = 1 << 3
sys_tracing = '/sys/kernel/debug/tracing'
@@ -378,9 +357,6 @@ class Event(object):
tracepoint, 'id')
id = int(file(id_path).read())
attr.config = id
- attr.sample_type = (PERF_SAMPLE_RAW
- | PERF_SAMPLE_TIME
- | PERF_SAMPLE_CPU)
attr.sample_period = 1
attr.read_format = PERF_FORMAT_GROUP
group_leader = -1
--
2.3.0
next prev parent reply other threads:[~2016-01-11 15:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 15:17 [Qemu-devel] [PATCH v2 00/34] kvm_stat: Cleanup and fixup Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 01/34] scripts/kvm/kvm_stat: Cleanup of multiple imports Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 02/34] scripts/kvm/kvm_stat: Replaced os.listdir with os.walk Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 03/34] scripts/kvm/kvm_stat: Make constants uppercase Janosch Frank
2016-01-11 15:17 ` Janosch Frank [this message]
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 05/34] scripts/kvm/kvm_stat: Mark globals in functions Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 06/34] scripts/kvm/kvm_stat: Invert dictionaries Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 07/34] scripts/kvm/kvm_stat: Cleanup of path variables Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 08/34] scripts/kvm/kvm_stat: Improve debugfs access checking Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 09/34] scripts/kvm/kvm_stat: Introduce main function Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 10/34] scripts/kvm/kvm_stat: Fix spaces around keyword assignments Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 11/34] scripts/kvm/kvm_stat: Rename variables that redefine globals Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 12/34] scripts/kvm/kvm_stat: Moved DebugfsProvider Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 13/34] scripts/kvm/kvm_stat: Fixup syscall error reporting Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 14/34] scripts/kvm/kvm_stat: Set sensible no. files rlimit Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 15/34] scripts/kvm/kvm_stat: Cleanup of platform detection Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 16/34] scripts/kvm/kvm_stat: Make cpu detection a function Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 17/34] scripts/kvm/kvm_stat: Rename _perf_event_open Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 18/34] scripts/kvm/kvm_stat: Introduce properties for providers Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 19/34] scripts/kvm/kvm_stat: Cleanup of TracepointProvider Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 20/34] scripts/kvm/kvm_stat: Cleanup cpu list retrieval Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 21/34] scripts/kvm/kvm_stat: Encapsulate filters variable Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 22/34] scripts/kvm/kvm_stat: Cleanup of Stats class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 23/34] scripts/kvm/kvm_stat: Cleanup of Groups class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 24/34] scripts/kvm/kvm_stat: Cleanup of Event class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 25/34] scripts/kvm/kvm_stat: Group arch specific data Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 26/34] scripts/kvm/kvm_stat: Remove unneeded X86_EXIT_REASONS Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 27/34] scripts/kvm/kvm_stat: Make tui function a class Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 28/34] scripts/kvm/kvm_stat: Fix output formatting Janosch Frank
2016-01-11 15:17 ` [Qemu-devel] [PATCH v2 29/34] scripts/kvm/kvm_stat: Cleanup and pre-init perf_event_attr Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 30/34] scripts/kvm/kvm_stat: Read event values as u64 Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 31/34] scripts/kvm/kvm_stat: Fix rlimit for unprivileged users Janosch Frank
2016-01-20 11:03 ` Paolo Bonzini
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 32/34] scripts/kvm/kvm_stat: Fixup filtering Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 33/34] scripts/kvm/kvm_stat: Add interactive filtering Janosch Frank
2016-01-11 15:18 ` [Qemu-devel] [PATCH v2 34/34] scripts/kvm/kvm_stat: Add optparse description Janosch Frank
2016-01-20 11:08 ` [Qemu-devel] [PATCH v2 00/34] kvm_stat: Cleanup and fixup Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452525484-32309-5-git-send-email-frankja@linux.vnet.ibm.com \
--to=frankja@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).