From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO11b-0004Zn-KM for qemu-devel@nongnu.org; Tue, 26 Jan 2016 05:39:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO11X-0007Hd-1X for qemu-devel@nongnu.org; Tue, 26 Jan 2016 05:39:03 -0500 From: Fam Zheng Date: Tue, 26 Jan 2016 18:38:11 +0800 Message-Id: <1453804705-7205-3-git-send-email-famz@redhat.com> In-Reply-To: <1453804705-7205-1-git-send-email-famz@redhat.com> References: <1453804705-7205-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [RFC PATCH 02/16] block: Set dirty before doing write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, jsnow@redhat.com, Markus Armbruster , mreitz@redhat.com, vsementsov@parallels.com, Stefan Hajnoczi So that driver can write the dirty bits into persistent dirty bitmaps in the write callback. Signed-off-by: Fam Zheng --- block/io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c index 343ff1f..b964e7e 100644 --- a/block/io.c +++ b/block/io.c @@ -1164,6 +1164,8 @@ static int coroutine_fn bdrv_aligned_pwritev(BlockDriverState *bs, } } + bdrv_set_dirty(bs, sector_num, nb_sectors); + if (ret < 0) { /* Do nothing, write notifier decided to fail this request */ } else if (flags & BDRV_REQ_ZERO_WRITE) { @@ -1179,8 +1181,6 @@ static int coroutine_fn bdrv_aligned_pwritev(BlockDriverState *bs, ret = bdrv_co_flush(bs); } - bdrv_set_dirty(bs, sector_num, nb_sectors); - if (bs->wr_highest_offset < offset + bytes) { bs->wr_highest_offset = offset + bytes; } -- 2.4.3